mpusz/mp-units
1
0
Fork 1
mirror of https://github.com/mpusz/mp-units.git synced 2025-08-04 12:54:25 +02:00
Code Issues Packages Projects Releases Wiki Activity

Address review comments

Browse Source
This commit is contained in:
Chip Hogg
2022-04-09 15:39:29 +00:00
parent 2c31bf83ec
commit 44cccfc743
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/core/include/units/magnitude.h
View File

@@ -493,7 +493,7 @@ constexpr auto integer_part(magnitude<BP>)
constexpr auto power_den = denominator(BP.power); constexpr auto power_den = denominator(BP.power);
if constexpr (std::is_integral_v<decltype(BP.get_base())> && (power_num >= power_den)) { if constexpr (std::is_integral_v<decltype(BP.get_base())> && (power_num >= power_den)) {
constexpr auto largest_integer_power = [power_num, power_den](BasePower auto bp) { constexpr auto largest_integer_power = [=](BasePower auto bp) {
bp.power = (power_num / power_den); // Note: integer division intended. bp.power = (power_num / power_den); // Note: integer division intended.
return bp; return bp;
}(BP); // Note: lambda is immediately invoked. }(BP); // Note: lambda is immediately invoked.
@@ -516,9 +516,8 @@ constexpr auto denominator(Magnitude auto m) { return numerator(pow<-1>(m)); }
// Implementation of conversion to ratio goes here, because it needs `numerator()` and `denominator()`. // Implementation of conversion to ratio goes here, because it needs `numerator()` and `denominator()`.
constexpr ratio as_ratio(Magnitude auto m) constexpr ratio as_ratio(Magnitude auto m)
requires(is_rational(decltype(m){}))
{ {
static_assert(is_rational(m));
return ratio{ return ratio{
get_value<std::intmax_t>(numerator(m)), get_value<std::intmax_t>(numerator(m)),
get_value<std::intmax_t>(denominator(m)), get_value<std::intmax_t>(denominator(m)),