From 658c0950f8808bd430330dce3458887fb1f9ba26 Mon Sep 17 00:00:00 2001
From: Mateusz Pusz <mateusz.pusz@gmail.com>
Date: Sat, 16 Nov 2024 21:59:40 +0100
Subject: [PATCH] refactor: `dimension_symbol` and `unit_symbol` refactored to
 use a variable template for caching result

---
 src/core/include/mp-units/framework/dimension.h | 6 ++----
 src/core/include/mp-units/framework/unit.h      | 6 ++----
 2 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/src/core/include/mp-units/framework/dimension.h b/src/core/include/mp-units/framework/dimension.h
index 73223ccb..a1ca00ce 100644
--- a/src/core/include/mp-units/framework/dimension.h
+++ b/src/core/include/mp-units/framework/dimension.h
@@ -301,9 +301,7 @@ MP_UNITS_EXPORT template<dimension_symbol_formatting fmt, typename CharT, Dimens
 }
 
 template<dimension_symbol_formatting fmt, typename CharT, Dimension D>
-struct dimension_symbol_result {
-  static constexpr auto value = dimension_symbol_impl<fmt, CharT>(D{});
-};
+constexpr auto dimension_symbol_result = dimension_symbol_impl<fmt, CharT>(D{});
 
 }  // namespace detail
 
@@ -312,7 +310,7 @@ MP_UNITS_EXPORT template<dimension_symbol_formatting fmt = dimension_symbol_form
                          Dimension D>
 [[nodiscard]] consteval std::string_view dimension_symbol(D)
 {
-  return detail::dimension_symbol_result<fmt, CharT, D>::value.view();
+  return detail::dimension_symbol_result<fmt, CharT, D>.view();
 }
 
 }  // namespace mp_units
diff --git a/src/core/include/mp-units/framework/unit.h b/src/core/include/mp-units/framework/unit.h
index fa5edf14..e421b841 100644
--- a/src/core/include/mp-units/framework/unit.h
+++ b/src/core/include/mp-units/framework/unit.h
@@ -904,9 +904,7 @@ MP_UNITS_EXPORT template<unit_symbol_formatting fmt, typename CharT, Unit U>
 }
 
 template<unit_symbol_formatting fmt, typename CharT, Unit U>
-struct unit_symbol_result {
-  static constexpr auto value = unit_symbol_impl<fmt, CharT>(U{});
-};
+constexpr auto unit_symbol_result = unit_symbol_impl<fmt, CharT>(U{});
 
 }  // namespace detail
 
@@ -914,7 +912,7 @@ struct unit_symbol_result {
 MP_UNITS_EXPORT template<unit_symbol_formatting fmt = unit_symbol_formatting{}, typename CharT = char, Unit U>
 [[nodiscard]] consteval std::string_view unit_symbol(U)
 {
-  return detail::unit_symbol_result<fmt, CharT, U>::value.view();
+  return detail::unit_symbol_result<fmt, CharT, U>.view();
 }
 
 }  // namespace mp_units