From 6b80ef6302561346aaacb52b617c8f3ee700d9e8 Mon Sep 17 00:00:00 2001 From: Mateusz Pusz Date: Sun, 9 Mar 2025 16:39:17 +0100 Subject: [PATCH] fix: setting `MP_UNITS_EXPLICIT_THIS_PARAMETER_SUPPORTED` fixed to account for C++ version Resolves #685 --- src/CMakeLists.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 8bb70e4d..293aa3af 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -66,7 +66,9 @@ endif() # clang++-18 supports explicit `this` parameter # https://github.com/llvm/llvm-project/issues/82780 -if(NOT ${projectPrefix}EXPLICIT_THIS_PARAMETER_SUPPORTED AND CMAKE_CXX_COMPILER_ID STREQUAL "Clang" +if(NOT ${projectPrefix}EXPLICIT_THIS_PARAMETER_SUPPORTED + AND CMAKE_CXX_STANDARD GREATER_EQUAL 23 + AND CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "18" ) message(STATUS "Clang 18+ detected, overriding `no CRTP` support")