From ae69e2e2b65644916169db4133d15a533e3bb101 Mon Sep 17 00:00:00 2001
From: Mateusz Pusz <mateusz.pusz@gmail.com>
Date: Mon, 6 Nov 2023 16:52:10 -1000
Subject: [PATCH] fix: `are_ingredients_convertible` now mandates explicit
 conversion for `To` dimensionless quantities

---
 src/core/include/mp-units/quantity_spec.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/core/include/mp-units/quantity_spec.h b/src/core/include/mp-units/quantity_spec.h
index 900362dd..65766906 100644
--- a/src/core/include/mp-units/quantity_spec.h
+++ b/src/core/include/mp-units/quantity_spec.h
@@ -1238,7 +1238,7 @@ template<typename... NumsTo, typename... DensTo>
                                                                              type_list<NumsTo...>, type_list<DensTo...>)
 {
   if constexpr (((... * map_power(NumsTo{})) / (... * map_power(DensTo{}))).dimension == dimension_one)
-    return specs_convertible_result::yes;
+    return specs_convertible_result::explicit_conversion;
   else
     return specs_convertible_result::no;
 }
@@ -1268,17 +1268,17 @@ template<typename... NumsTo>
                                                                              type_list<NumsTo...>, type_list<>)
 {
   if constexpr ((... * map_power(NumsTo{})).dimension == dimension_one)
-    return specs_convertible_result::yes;
+    return specs_convertible_result::explicit_conversion;
   else
     return specs_convertible_result::no;
 }
 
-template<typename... DensFrom>
+template<typename... DensTo>
 [[nodiscard]] consteval specs_convertible_result are_ingredients_convertible(type_list<>, type_list<>, type_list<>,
-                                                                             type_list<DensFrom...>)
+                                                                             type_list<DensTo...>)
 {
-  if constexpr ((... * map_power(DensFrom{})).dimension == dimension_one)
-    return specs_convertible_result::yes;
+  if constexpr ((... * map_power(DensTo{})).dimension == dimension_one)
+    return specs_convertible_result::explicit_conversion;
   else
     return specs_convertible_result::no;
 }