mpusz/mp-units
1
0
Fork 1
mirror of https://github.com/mpusz/mp-units.git synced 2025-08-03 20:34:26 +02:00
Code Issues Packages Projects Releases Wiki Activity

refactor: quantity_spec::operator[] return type constrained with Reference concept

Browse Source
This commit is contained in:
Mateusz Pusz
2022-12-22 16:48:28 +01:00
parent a32eb712da
commit be58a6e03a
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/core/include/units/quantity_spec.h
View File

@@ -233,7 +233,7 @@ struct derived_quantity_spec : detail::expr_fractions<derived_quantity_spec<>, Q
#ifdef __cpp_explicit_this_parameter
template<typename Self, Unit U>
[[nodiscard]] consteval auto operator[](this const Self, U u)
[[nodiscard]] consteval Reference auto operator[](this const Self, U u)
requires(dimension == detail::get_dimension_for(u))
{
return reference<Self{}, u>{};
@@ -241,7 +241,7 @@ struct derived_quantity_spec : detail::expr_fractions<derived_quantity_spec<>, Q
#else
// TODO can we somehow return an explicit reference type here?
template<Unit U>
[[nodiscard]] consteval auto operator[](U u) const
[[nodiscard]] consteval Reference auto operator[](U u) const
requires(dimension == detail::get_dimension_for(u))
{
return reference<derived_quantity_spec{}, u>{};
@@ -318,12 +318,12 @@ struct quantity_spec<Self, Dim, Args...> {
#ifdef __cpp_explicit_this_parameter
template<typename Self, Unit U>
[[nodiscard]] consteval auto operator[](this const Self, U u)
[[nodiscard]] consteval Reference auto operator[](this const Self, U u)
requires(dimension == detail::get_dimension_for(u))
#else
template<Unit U>
// TODO can we somehow return an explicit reference type here?
[[nodiscard]] consteval auto operator[](U u) const
[[nodiscard]] consteval Reference auto operator[](U u) const
requires(dimension == detail::get_dimension_for(u))
#endif
{
@@ -386,7 +386,7 @@ struct quantity_spec<Self, Q, Args...> : std::remove_const_t<decltype(Q)> {
#ifndef __cpp_explicit_this_parameter
template<Unit U>
// TODO can we somehow return an explicit reference type here?
[[nodiscard]] consteval auto operator[](U u) const
[[nodiscard]] consteval Reference auto operator[](U u) const
requires(this->dimension == detail::get_dimension_for(u))
{
return reference<Self{}, u>{};