From c7d7c7d49fd4a510b05423a9e78759999c23dc68 Mon Sep 17 00:00:00 2001 From: Mateusz Pusz Date: Thu, 29 Dec 2022 19:00:15 +0100 Subject: [PATCH] refactor: `isq_angle` refactored after consulting with Paul Quincey --- src/systems/isq_angle/include/units/isq_angle/isq_angle.h | 1 - test/unit_test/static/isq_angle_test.cpp | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/systems/isq_angle/include/units/isq_angle/isq_angle.h b/src/systems/isq_angle/include/units/isq_angle/isq_angle.h index f1d3455b..42340fde 100644 --- a/src/systems/isq_angle/include/units/isq_angle/isq_angle.h +++ b/src/systems/isq_angle/include/units/isq_angle/isq_angle.h @@ -32,7 +32,6 @@ using namespace isq; // ISQ angular derived quantities redefinition QUANTITY_SPEC(cotes_angle_constant, angular::angle); // 1 rad -QUANTITY_SPEC(arc_length, length*(angular::angle / cotes_angle_constant)); QUANTITY_SPEC(angular_measure, cotes_angle_constant* arc_length / radius); QUANTITY_SPEC(rotational_displacement, cotes_angle_constant* path_length / radius); inline constexpr auto angular_displacement = rotational_displacement; diff --git a/test/unit_test/static/isq_angle_test.cpp b/test/unit_test/static/isq_angle_test.cpp index 02d21c17..90fce27a 100644 --- a/test/unit_test/static/isq_angle_test.cpp +++ b/test/unit_test/static/isq_angle_test.cpp @@ -38,7 +38,6 @@ using enum units::quantity_character; } static_assert(verify(isq_angle::cotes_angle_constant, scalar, rad)); -static_assert(verify(isq_angle::arc_length, scalar, m)); static_assert(verify(isq_angle::angular_measure, scalar, rad)); static_assert(verify(isq_angle::rotational_displacement, scalar, rad)); static_assert(verify(isq_angle::angular_displacement, scalar, rad)); @@ -51,7 +50,7 @@ static_assert(verify(isq_angle::angular_repetency, scalar, rad / m)); static_assert(verify(isq_angle::angular_wavenumber, scalar, rad / m)); static_assert(verify(isq_angle::phase_coefficient, scalar, rad / m)); static_assert(verify(isq_angle::propagation_coefficient, scalar, rad / m)); -static_assert(verify(isq_angle::moment_of_inertia, tensor, kg* m2 / rad2)); // TODO steradian? +static_assert(verify(isq_angle::moment_of_inertia, tensor, kg* m2 / rad2)); static_assert(verify(isq_angle::angular_momentum, vector, J* s / rad)); static_assert(verify(isq_angle::moment_of_force, vector, J / rad)); static_assert(verify(isq_angle::torque, scalar, J / rad));