From cbed8b06b8c8669465ba7107d13e022fb4ce0a56 Mon Sep 17 00:00:00 2001 From: Mateusz Pusz Date: Sun, 7 Nov 2021 09:19:00 +0100 Subject: [PATCH 1/2] docs: fexed broken link to LA library Resolves #308 --- docs/usage.rst | 2 +- docs/use_cases/linear_algebra.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/usage.rst b/docs/usage.rst index ca3c2ae3..68f34655 100644 --- a/docs/usage.rst +++ b/docs/usage.rst @@ -32,7 +32,7 @@ This repository contains three independent CMake-based projects: - additionally to the dependencies of *./src* project, it uses: - `Catch2 `_ library as a unit tests framework. - - `linear algebra `_ + - `linear algebra `_ library based on proposal `P1385 `_ used in some examples and tests. - `Doxygen `_ to extract C++ entities information from the source diff --git a/docs/use_cases/linear_algebra.rst b/docs/use_cases/linear_algebra.rst index edefb482..6cc017b0 100644 --- a/docs/use_cases/linear_algebra.rst +++ b/docs/use_cases/linear_algebra.rst @@ -10,7 +10,7 @@ enough to be used with other Linear Algebra libraries existing on the market. All of the examples provided in this chapter refer to the official proposal of the Linear Algebra Library for the C++23 defined in `P1385 `_ - and its latest implementation from `GitHub `_ + and its latest implementation from `GitHub `_ or `Conan `_. Also, to simplify the examples all of them assume:: From 44a8d0ad1ec920751928a60c82fc580dc2515537 Mon Sep 17 00:00:00 2001 From: Mateusz Pusz Date: Sun, 7 Nov 2021 09:42:15 +0100 Subject: [PATCH 2/2] build: forgot to commit changes in one CMake file :-( --- src/core/CMakeLists.txt | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/core/CMakeLists.txt b/src/core/CMakeLists.txt index 920e61dc..e73e63f7 100644 --- a/src/core/CMakeLists.txt +++ b/src/core/CMakeLists.txt @@ -23,15 +23,15 @@ cmake_minimum_required(VERSION 3.15) # core library options -set(${ProjectPrefix}DOWNCAST_MODE ON CACHE STRING "Select downcasting mode") -set_property(CACHE ${ProjectPrefix}DOWNCAST_MODE PROPERTY STRINGS AUTO ON OFF) +set(${projectPrefix}DOWNCAST_MODE ON CACHE STRING "Select downcasting mode") +set_property(CACHE ${projectPrefix}DOWNCAST_MODE PROPERTY STRINGS AUTO ON OFF) # find dependencies find_package(gsl-lite CONFIG REQUIRED) # check if libc++ is being used include(CheckLibcxxInUse) -check_libcxx_in_use(${ProjectPrefix}LIBCXX) +check_libcxx_in_use(${projectPrefix}LIBCXX) # core library definition add_library(mp-units-core INTERFACE) @@ -45,7 +45,7 @@ target_include_directories(mp-units-core ${unitsAsSystem} INTERFACE ) if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang") - if(${ProjectPrefix}LIBCXX) + if(${projectPrefix}LIBCXX) find_package(range-v3 CONFIG REQUIRED) target_link_libraries(mp-units-core INTERFACE range-v3::range-v3) endif() @@ -55,14 +55,14 @@ elseif(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC") ) endif() -if(DEFINED ${ProjectPrefix}DOWNCAST_MODE) +if(DEFINED ${projectPrefix}DOWNCAST_MODE) set(downcast_mode_options OFF ON AUTO) - list(FIND downcast_mode_options "${${ProjectPrefix}DOWNCAST_MODE}" downcast_mode) + list(FIND downcast_mode_options "${${projectPrefix}DOWNCAST_MODE}" downcast_mode) if(downcast_mode EQUAL -1) - message(FATAL_ERROR "'${ProjectPrefix}DOWNCAST_MODE' should be one of ${downcast_mode_options} ('${${ProjectPrefix}DOWNCAST_MODE}' received)") + message(FATAL_ERROR "'${projectPrefix}DOWNCAST_MODE' should be one of ${downcast_mode_options} ('${${projectPrefix}DOWNCAST_MODE}' received)") else() - message(STATUS "${ProjectPrefix}DOWNCAST_MODE: ${${ProjectPrefix}DOWNCAST_MODE}") - target_compile_definitions(mp-units-core INTERFACE ${ProjectPrefix}DOWNCAST_MODE=${downcast_mode}) + message(STATUS "${projectPrefix}DOWNCAST_MODE: ${${projectPrefix}DOWNCAST_MODE}") + target_compile_definitions(mp-units-core INTERFACE ${projectPrefix}DOWNCAST_MODE=${downcast_mode}) endif() endif()