From e0ce43c5efe9a9a5587a7d48878646b9131ff3a4 Mon Sep 17 00:00:00 2001
From: Mateusz Pusz <mateusz.pusz@gmail.com>
Date: Thu, 3 Apr 2025 16:05:31 +0100
Subject: [PATCH] feat: `IsFloatingPoint` removed and replaced with
 `treat_as_floating_point`

---
 src/core/include/mp-units/framework/quantity.h | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/src/core/include/mp-units/framework/quantity.h b/src/core/include/mp-units/framework/quantity.h
index 4b64a707..3ad8f563 100644
--- a/src/core/include/mp-units/framework/quantity.h
+++ b/src/core/include/mp-units/framework/quantity.h
@@ -61,15 +61,13 @@ template<Unit UFrom, Unit UTo>
     return is_integral(get_canonical_unit(from).mag / get_canonical_unit(to).mag);
 }
 
-template<typename T>
-concept IsFloatingPoint = treat_as_floating_point<T>;
-
 template<typename FromRep, typename ToRep, auto FromUnit, auto ToUnit>
-concept ValuePreservingTo = Unit<MP_UNITS_REMOVE_CONST(decltype(FromUnit))> &&
-                            Unit<MP_UNITS_REMOVE_CONST(decltype(ToUnit))> && std::assignable_from<ToRep&, FromRep> &&
-                            (IsFloatingPoint<ToRep> || (!IsFloatingPoint<std::remove_cvref_t<FromRep>> &&
-                                                        integral_conversion_factor(FromUnit, ToUnit) &&
-                                                        !overflows_non_zero_values<ToRep>(FromUnit, ToUnit)));
+concept ValuePreservingTo =
+  Unit<MP_UNITS_REMOVE_CONST(decltype(FromUnit))> && Unit<MP_UNITS_REMOVE_CONST(decltype(ToUnit))> &&
+  std::assignable_from<ToRep&, FromRep> &&
+  (treat_as_floating_point<ToRep> ||
+   (!treat_as_floating_point<std::remove_cvref_t<FromRep>> && integral_conversion_factor(FromUnit, ToUnit) &&
+    !overflows_non_zero_values<ToRep>(FromUnit, ToUnit)));
 
 template<typename FromRep, typename ToRep, auto QS>
 concept RepresentationValuePreservingTo =