diff --git a/cmake/warnings.cmake b/cmake/warnings.cmake index e810146b..03c8fac3 100644 --- a/cmake/warnings.cmake +++ b/cmake/warnings.cmake @@ -67,6 +67,7 @@ function(set_warnings target scope) /w14928 # illegal copy-initialization; more than one user-defined # conversion has been implicitly applied /permissive- # standards conformance mode for MSVC compiler. + /wd4244 # ) set(CLANG_WARNINGS @@ -82,8 +83,8 @@ function(set_warnings target scope) -Wunused # warn on anything being unused -Woverloaded-virtual # warn if you overload (not override) a virtual function -Wcast-qual # warn on dropping const or volatile qualifiers - -Wconversion # warn on type conversions that may lose data - -Wsign-conversion # warn on sign conversions + # -Wconversion # warn on type conversions that may lose data + # -Wsign-conversion # warn on sign conversions -Wnull-dereference # warn if a null dereference is detected -Wdouble-promotion # warn if float is implicit promoted to double -Wformat=2 # warn on security issues around functions that format output (ie printf) diff --git a/src/include/units/quantity.h b/src/include/units/quantity.h index 7013d6a3..8911cc73 100644 --- a/src/include/units/quantity.h +++ b/src/include/units/quantity.h @@ -134,7 +134,7 @@ public: template Value> explicit(!(is_same_v && is_same_v)) - constexpr quantity(const Value& v) : value_(static_cast(v)) {} + constexpr quantity(const Value& v) : value_(v) {} template Q> constexpr quantity(const Q& q) : value_(quantity_cast(q).count()) {} diff --git a/test/unit_test/static/CMakeLists.txt b/test/unit_test/static/CMakeLists.txt index d01adfce..d44aa529 100644 --- a/test/unit_test/static/CMakeLists.txt +++ b/test/unit_test/static/CMakeLists.txt @@ -51,5 +51,3 @@ target_link_libraries(unit_tests_static PRIVATE mp::units ) - -set_source_files_properties(quantity_test.cpp PROPERTIES COMPILE_OPTIONS $,/wd4244,-Wno-conversion>)