From fb602a449731fcdd6734646c5446a4f95eb78fcd Mon Sep 17 00:00:00 2001
From: Chip Hogg <chogg@aurora.tech>
Date: Wed, 12 Jan 2022 09:47:40 -0500
Subject: [PATCH] Try fixing "unreachable code" warning on MSVC 14.2

This doesn't show up on any other compiler, including MSVC 14.3, so I
think it's just a compiler bug.  Cursory googling suggests perhaps that
some older versions of MSVC have immature support for `if constexpr`.
---
 src/core/include/units/magnitude.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/core/include/units/magnitude.h b/src/core/include/units/magnitude.h
index df2b5507..c9013bd1 100644
--- a/src/core/include/units/magnitude.h
+++ b/src/core/include/units/magnitude.h
@@ -306,12 +306,14 @@ constexpr auto operator*(magnitude<H1, T1...>, magnitude<H2, T2...>) {
       return magnitude<new_head>{} * partial_product;
     }
   }
+
   // Case for when H1 has the smaller base.
-  else if constexpr(H1.get_base() < H2.get_base()){
+  if constexpr(H1.get_base() < H2.get_base()){
     return magnitude<H1>{} * (magnitude<T1...>{} * magnitude<H2, T2...>{});
   }
+
   // Case for when H2 has the smaller base.
-  else {
+  if constexpr(H1.get_base() > H2.get_base()){
     return magnitude<H2>{} * (magnitude<H1, T1...>{} * magnitude<T2...>{});
   }
 }