From fbe384a4761ebce8679a9994aec392e554669caa Mon Sep 17 00:00:00 2001
From: Mateusz Pusz <mateusz.pusz@gmail.com>
Date: Fri, 4 Oct 2024 14:55:59 +0200
Subject: [PATCH] feat: TagType concept added

---
 src/core/include/mp-units/ext/type_traits.h                | 7 +++++++
 src/core/include/mp-units/framework/dimension_concepts.h   | 2 +-
 .../include/mp-units/framework/quantity_point_concepts.h   | 2 +-
 .../include/mp-units/framework/quantity_spec_concepts.h    | 3 +--
 src/core/include/mp-units/framework/unit_concepts.h        | 2 +-
 5 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/src/core/include/mp-units/ext/type_traits.h b/src/core/include/mp-units/ext/type_traits.h
index 74a14139..965444f5 100644
--- a/src/core/include/mp-units/ext/type_traits.h
+++ b/src/core/include/mp-units/ext/type_traits.h
@@ -207,4 +207,11 @@ template<template<auto...> typename T, typename T1, typename T2, typename... Ts>
     return get<T, T2, Ts...>();
 }
 
+namespace detail {
+
+template<typename T>
+concept TagType = std::is_empty_v<T> && std::is_final_v<T>;
+
+}
+
 }  // namespace mp_units
diff --git a/src/core/include/mp-units/framework/dimension_concepts.h b/src/core/include/mp-units/framework/dimension_concepts.h
index ee2d7d9c..60539ee5 100644
--- a/src/core/include/mp-units/framework/dimension_concepts.h
+++ b/src/core/include/mp-units/framework/dimension_concepts.h
@@ -42,7 +42,7 @@ struct dimension_interface;
  * Satisfied by all dimension types in the library.
  */
 MP_UNITS_EXPORT template<typename T>
-concept Dimension = std::derived_from<T, detail::dimension_interface> && std::is_empty_v<T> && std::is_final_v<T>;
+concept Dimension = detail::TagType<T> && std::derived_from<T, detail::dimension_interface>;
 
 MP_UNITS_EXPORT template<symbol_text Symbol>
 struct base_dimension;
diff --git a/src/core/include/mp-units/framework/quantity_point_concepts.h b/src/core/include/mp-units/framework/quantity_point_concepts.h
index 4537428f..3e40b7df 100644
--- a/src/core/include/mp-units/framework/quantity_point_concepts.h
+++ b/src/core/include/mp-units/framework/quantity_point_concepts.h
@@ -65,7 +65,7 @@ struct point_origin_interface;
  * Satisfied by either quantity points or by all types derived from `absolute_point_origin` class template.
  */
 MP_UNITS_EXPORT template<typename T>
-concept PointOrigin = std::derived_from<T, detail::point_origin_interface> && std::is_empty_v<T> && std::is_final_v<T>;
+concept PointOrigin = detail::TagType<T> && std::derived_from<T, detail::point_origin_interface>;
 
 /**
  * @brief A concept matching all quantity point origins for a specified quantity type in the library
diff --git a/src/core/include/mp-units/framework/quantity_spec_concepts.h b/src/core/include/mp-units/framework/quantity_spec_concepts.h
index 8464954b..90792dd9 100644
--- a/src/core/include/mp-units/framework/quantity_spec_concepts.h
+++ b/src/core/include/mp-units/framework/quantity_spec_concepts.h
@@ -37,8 +37,7 @@ struct quantity_spec_interface_base;
 }
 
 MP_UNITS_EXPORT template<typename T>
-concept QuantitySpec =
-  std::derived_from<T, detail::quantity_spec_interface_base> && std::is_empty_v<T> && std::is_final_v<T>;
+concept QuantitySpec = detail::TagType<T> && std::derived_from<T, detail::quantity_spec_interface_base>;
 
 MP_UNITS_EXPORT
 #if MP_UNITS_API_NO_CRTP
diff --git a/src/core/include/mp-units/framework/unit_concepts.h b/src/core/include/mp-units/framework/unit_concepts.h
index c0859345..b7379f4b 100644
--- a/src/core/include/mp-units/framework/unit_concepts.h
+++ b/src/core/include/mp-units/framework/unit_concepts.h
@@ -43,7 +43,7 @@ struct unit_interface;
  * Satisfied by all unit types provided by the library.
  */
 MP_UNITS_EXPORT template<typename T>
-concept Unit = std::derived_from<T, detail::unit_interface> && std::is_empty_v<T> && std::is_final_v<T>;
+concept Unit = detail::TagType<T> && std::derived_from<T, detail::unit_interface>;
 
 template<Magnitude auto M, Unit U>
   requires(M != magnitude<>{} && M != mag<1>)