From 346580d95515d3dc2b8f401f4e8058ed1d31ccd2 Mon Sep 17 00:00:00 2001
From: Ivan Kravets <me@ikravets.com>
Date: Sat, 19 Mar 2022 18:13:29 +0200
Subject: [PATCH] Do not warn about unknown packages if they are built-in
 libraries

---
 platformio/package/manager/_install.py | 23 +++++++++++------------
 tests/commands/pkg/test_uninstall.py   |  1 -
 2 files changed, 11 insertions(+), 13 deletions(-)

diff --git a/platformio/package/manager/_install.py b/platformio/package/manager/_install.py
index f2d75992..2962aec7 100644
--- a/platformio/package/manager/_install.py
+++ b/platformio/package/manager/_install.py
@@ -125,14 +125,17 @@ class PackageManagerInstallMixin(object):
         if print_header:
             self.log.info("Resolving dependencies...")
         for dependency in dependencies:
-            if not self._install_dependency(dependency):
-                self.log.warning(
-                    click.style(
-                        "Warning! Could not install dependency %s for package '%s'"
-                        % (dependency, pkg.metadata.name),
-                        fg="yellow",
+            try:
+                self._install_dependency(dependency)
+            except UnknownPackageError:
+                if dependency.get("owner"):
+                    self.log.warning(
+                        click.style(
+                            "Warning! Could not install dependency %s for package '%s'"
+                            % (dependency, pkg.metadata.name),
+                            fg="yellow",
+                        )
                     )
-                )
 
     def _install_dependency(self, dependency):
         spec = PackageSpec(
@@ -145,11 +148,7 @@ class PackageManagerInstallMixin(object):
             for key, value in dependency.items()
             if key in ("authors", "platforms", "frameworks")
         }
-        try:
-            return self._install(spec, search_filters=search_filters or None)
-        except UnknownPackageError:
-            pass
-        return None
+        return self._install(spec, search_filters=search_filters or None)
 
     def install_from_url(self, url, spec, checksum=None):
         spec = self.ensure_spec(spec)
diff --git a/tests/commands/pkg/test_uninstall.py b/tests/commands/pkg/test_uninstall.py
index 3fc8f3ec..1dae981c 100644
--- a/tests/commands/pkg/test_uninstall.py
+++ b/tests/commands/pkg/test_uninstall.py
@@ -56,7 +56,6 @@ def test_global_packages(
         ],
     )
     validate_cliresult(result)
-    assert "Warning! Could not install dependency {'name': 'Hash'" in result.output
     assert pkgs_to_names(LibraryPackageManager().get_installed()) == [
         "ArduinoJson",
         "AsyncMqttClient",