platformio/platformio-core
1
0
Fork 1
mirror of https://github.com/platformio/platformio-core.git synced 2025-10-27 04:01:40 +01:00
Code Issues Packages Projects Releases Wiki Activity

Handle possible issues when check tool cannot be executed // Resolve #3753

Browse Source 
Now, each tool individually decides under what conditions the check is considered failed.
This commit is contained in:
valeros
2020-12-22 00:21:32 +02:00
parent d485703768
commit 6e958b8415
5 changed files with 66 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
tests/commands/test_check.py
View File

@@ -410,6 +410,22 @@ check_tool = pvs-studio
assert style == 0
def test_check_pvs_studio_fails_without_license(clirunner, tmpdir):
config = DEFAULT_CONFIG + "\ncheck_tool = pvs-studio"
tmpdir.join("platformio.ini").write(config)
tmpdir.mkdir("src").join("main.c").write(TEST_CODE)
default_result = clirunner.invoke(cmd_check, ["--project-dir", str(tmpdir)])
verbose_result = clirunner.invoke(cmd_check, ["--project-dir", str(tmpdir), "-v"])
assert default_result.exit_code != 0
assert "failed to perform check" in default_result.output.lower()
assert verbose_result.exit_code != 0
assert "license was not entered" in verbose_result.output.lower()
def test_check_embedded_platform_all_tools(clirunner, validate_cliresult, tmpdir):
config = """
[env:test]