From 98a1fd79b62a4b44c402330345487b659470d8f4 Mon Sep 17 00:00:00 2001 From: Ivan Kravets Date: Fri, 19 Oct 2018 16:13:55 +0300 Subject: [PATCH] Revert back "Handle first part for package name" --- platformio/managers/package.py | 2 +- tests/test_managers.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/platformio/managers/package.py b/platformio/managers/package.py index 40bde023..b8db1f77 100644 --- a/platformio/managers/package.py +++ b/platformio/managers/package.py @@ -622,7 +622,7 @@ class BasePkgManager(PkgRepoMixin, PkgInstallerMixin): _url = _url[:-1] name = basename(_url) if "." in name and not name.startswith("."): - name = name.split(".", 1)[0] + name = name.rsplit(".", 1)[0] return (name or text, requirements, url) diff --git a/tests/test_managers.py b/tests/test_managers.py index 56b8fe15..ee2d5df1 100644 --- a/tests/test_managers.py +++ b/tests/test_managers.py @@ -54,7 +54,7 @@ def test_pkg_input_parser(): ], [ "https://somedomain.com/path/LibraryName-1.2.3.zip", - ("LibraryName-1", None, + ("LibraryName-1.2.3", None, "https://somedomain.com/path/LibraryName-1.2.3.zip") ], [ @@ -69,12 +69,12 @@ def test_pkg_input_parser(): ], [ "https://github.com/user/package/archive/branch.tar.gz", - ("branch", None, + ("branch.tar", None, "https://github.com/user/package/archive/branch.tar.gz") ], [ "https://github.com/user/package/archive/branch.tar.gz@!=5", - ("branch", "!=5", + ("branch.tar", "!=5", "https://github.com/user/package/archive/branch.tar.gz") ], [