From a73a710364a7f16ee1b96d1d4111a431c77ff0b8 Mon Sep 17 00:00:00 2001 From: Ivan Kravets Date: Sat, 9 Jul 2016 15:16:42 +0300 Subject: [PATCH] Iterating the dictionary directly instead of calling .keys() --- platformio/builder/scripts/frameworks/mbed.py | 2 +- platformio/builder/tools/platformio.py | 2 +- platformio/commands/lib.py | 2 +- platformio/maintenance.py | 4 ++-- platformio/telemetry.py | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/platformio/builder/scripts/frameworks/mbed.py b/platformio/builder/scripts/frameworks/mbed.py index 3c7dc2e0..16503122 100644 --- a/platformio/builder/scripts/frameworks/mbed.py +++ b/platformio/builder/scripts/frameworks/mbed.py @@ -86,7 +86,7 @@ MBED_LIBS_MAP = { def get_mbedlib_includes(): result = [] - for lib in MBED_LIBS_MAP.keys(): + for lib in MBED_LIBS_MAP: includes = [] lib_dir = join(env.subst("$PLATFORMFW_DIR"), "libs", lib) for _, _, files in walk(lib_dir): diff --git a/platformio/builder/tools/platformio.py b/platformio/builder/tools/platformio.py index e1b599c8..c9758fa1 100644 --- a/platformio/builder/tools/platformio.py +++ b/platformio/builder/tools/platformio.py @@ -154,7 +154,7 @@ def ProcessUnFlags(env, flags): all_flags.extend(items) all_flags = set(all_flags) - for key in parsed_flags.keys(): + for key in parsed_flags: cur_flags = set(env.get(key, [])) for item in cur_flags & all_flags: while item in env[key]: diff --git a/platformio/commands/lib.py b/platformio/commands/lib.py index f2bd73e5..bbf8bb09 100644 --- a/platformio/commands/lib.py +++ b/platformio/commands/lib.py @@ -153,7 +153,7 @@ def lib_install(ctx, libid, version): def lib_install_dependency(ctx, data): assert isinstance(data, dict) query = [] - for key in data.keys(): + for key in data: if key in ("authors", "frameworks", "platforms", "keywords"): values = data[key] if not isinstance(values, list): diff --git a/platformio/maintenance.py b/platformio/maintenance.py index 34395604..d2e944eb 100644 --- a/platformio/maintenance.py +++ b/platformio/maintenance.py @@ -101,7 +101,7 @@ class Upgrader(object): prev_platforms = [] # remove platform's folder (obsolete package structure) - for name in PlatformFactory.get_platforms().keys(): + for name in PlatformFactory.get_platforms(): pdir = join(get_home_dir(), name) if not isdir(pdir): continue @@ -234,7 +234,7 @@ def check_internal_updates(ctx, what): outdated_items = [] if what == "platforms": - for platform in PlatformFactory.get_platforms(installed=True).keys(): + for platform in PlatformFactory.get_platforms(installed=True): p = PlatformFactory.newPlatform(platform) if p.is_outdated(): outdated_items.append(platform) diff --git a/platformio/telemetry.py b/platformio/telemetry.py index 48ca79ab..f8fea43c 100644 --- a/platformio/telemetry.py +++ b/platformio/telemetry.py @@ -326,7 +326,7 @@ def backup_reports(items): for params in items: # skip static options - for key in params.keys(): + for key in params: if key in ("v", "tid", "cid", "cd1", "cd2", "sr", "an"): del params[key]