platformio/platformio-core
1
0
Fork 1
mirror of https://github.com/platformio/platformio-core.git synced 2025-07-31 18:44:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

make bash version check case insensitive (#4399)

Browse Source 
the output of `bash --version` is different when the system is configured for e.g. de_DE locale. For german locale the it's `GNU bash, Version 5.0…` with an uppercase 'V'. This makes the bash completion setup fail with the error `Error: The minimal supported Bash version is 4.4`.

To fix this, the version match regex now uses the `IGNORECASE` flag.
This commit is contained in:
Florian Sievers
2022-08-24 12:44:56 +02:00
committed by GitHub
parent 1cbc424488
commit af21c50aec
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
platformio/system/completion.py
View File

@@ -30,7 +30,7 @@ class ShellType(Enum):
def get_bash_version(): def get_bash_version():
result = subprocess.run(["bash", "--version"], capture_output=True, check=True) result = subprocess.run(["bash", "--version"], capture_output=True, check=True)
match = re.search(r"version\s+(\d+)\.(\d+)", result.stdout.decode()) match = re.search(r"version\s+(\d+)\.(\d+)", result.stdout.decode(), re.IGNORECASE)
if match: if match:
return (int(match.group(1)), int(match.group(2))) return (int(match.group(1)), int(match.group(2)))
return (0, 0) return (0, 0)