From f6aa95a4fe5993a6684321727436b9c5b1d4ac48 Mon Sep 17 00:00:00 2001 From: Dawid Nowak Date: Mon, 1 May 2023 13:30:27 +0200 Subject: [PATCH] test/runners/unity.py: fixed warnings: `[-Wunused-parameter]` (#4610) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit They appear when the tests are run with the `Wextra` flag. I know of 3 possible solutions: * A.) `static_cast(unusedParameter);` – the preferred C++ way, but `unity` can also be used with `C` * B.) `(void) unusedParameter;` – "old" C–style casting – the one I used – compatible with both C and C++ * C.) remove `unusedParameter` var from the function arguments – but keeping the name better explains what it is ``` Library Manager: Installing throwtheswitch/Unity @ ^2.5.2 Unpacking [####################################] 100% Library Manager: Unity@2.5.2 has been installed! .pio/build/native/unity_config/unity_config.c:39:37: warning: unused parameter 'baudrate' [-Wunused-parameter] void unityOutputStart(unsigned long baudrate) { } ^ 1 warning generated. Testing... ``` --- platformio/test/runners/unity.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/platformio/test/runners/unity.py b/platformio/test/runners/unity.py index 1c8ef795..25fea0ab 100644 --- a/platformio/test/runners/unity.py +++ b/platformio/test/runners/unity.py @@ -114,7 +114,7 @@ $framework_config_code native=dict( code=""" #include -void unityOutputStart(unsigned long baudrate) { } +void unityOutputStart(unsigned long baudrate) { (void) baudrate; } void unityOutputChar(unsigned int c) { putchar(c); } void unityOutputFlush(void) { fflush(stdout); } void unityOutputComplete(void) { } @@ -155,7 +155,7 @@ void unityOutputComplete(void) { } espidf=dict( code=""" #include -void unityOutputStart(unsigned long baudrate) { } +void unityOutputStart(unsigned long baudrate) { (void) baudrate; } void unityOutputChar(unsigned int c) { putchar(c); } void unityOutputFlush(void) { fflush(stdout); } void unityOutputComplete(void) { } @@ -165,7 +165,7 @@ void unityOutputComplete(void) { } zephyr=dict( code=""" #include -void unityOutputStart(unsigned long baudrate) { } +void unityOutputStart(unsigned long baudrate) { (void) baudrate; } void unityOutputChar(unsigned int c) { printk("%c", c); } void unityOutputFlush(void) { } void unityOutputComplete(void) { }