smarty-php/smarty
1
0
Fork 0
mirror of https://github.com/smarty-php/smarty.git synced 2025-11-02 21:31:48 +01:00
Code Issues Packages Projects Releases Wiki Activity

- bugfix {foreach} must keep the @properties when restoring a saved $item variable as the properties might be used outside {foreach} https://github.com/smarty-php/smarty/issues/267

Browse Source
This commit is contained in:
uwetews
2016-09-09 19:45:08 +02:00
parent 21aa211ddb
commit 0e942e4821
3 changed files with 15 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
libs/sysplugins/smarty_internal_runtime_foreach.php
View File

@@ -50,7 +50,7 @@ class Smarty_Internal_Runtime_Foreach
$total = empty($from) ? 0 : (($needTotal || isset($properties[ 'total' ])) ? count($from) : 1);
}
if (isset($tpl->tpl_vars[ $item ])) {
$saveVars[ $item ] = $tpl->tpl_vars[ $item ];
$saveVars[ 'item' ] = array($item, $tpl->tpl_vars[ $item ]);
}
$tpl->tpl_vars[ $item ] = new Smarty_Variable(null, $tpl->isRenderingCache);
if ($total === 0) {
@@ -58,7 +58,7 @@ class Smarty_Internal_Runtime_Foreach
} else {
if ($key) {
if (isset($tpl->tpl_vars[ $key ])) {
$saveVars[ $key ] = $tpl->tpl_vars[ $key ];
$saveVars[ 'key' ] = array($key, $tpl->tpl_vars[ $key ]);
}
$tpl->tpl_vars[ $key ] = new Smarty_Variable(null, $tpl->isRenderingCache);
}
@@ -69,7 +69,7 @@ class Smarty_Internal_Runtime_Foreach
if ($name) {
$namedVar = "__smarty_foreach_{$name}";
if (isset($tpl->tpl_vars[ $namedVar ])) {
$saveVars[ $namedVar ] = $tpl->tpl_vars[ $namedVar ];
$saveVars[ 'named' ] = array($namedVar, $tpl->tpl_vars[ $namedVar ]);
}
$namedProp = array();
if (isset($properties[ 'total' ])) {
@@ -97,8 +97,16 @@ class Smarty_Internal_Runtime_Foreach
*/
public function restore(Smarty_Internal_Template $tpl)
{
foreach (array_pop($this->stack) as $k => $v) {
$tpl->tpl_vars[ $k ] = $v;
$saveVars = array_pop($this->stack);
if (isset($saveVars['item'])) {
$item = &$saveVars['item'];
$tpl->tpl_vars[ $item[0] ]->value = $item[1]->value;
}
if (isset($saveVars['key'])) {
$tpl->tpl_vars[ $saveVars['key'][0] ] = $saveVars['key'][1];
}
if (isset($saveVars['named'])) {
$tpl->tpl_vars[ $saveVars['named'][0] ] = $saveVars['named'][1];
}
}