diff --git a/libs/plugins/function.counter.php b/libs/plugins/function.counter.php index 2536c14e..a186b4d5 100644 --- a/libs/plugins/function.counter.php +++ b/libs/plugins/function.counter.php @@ -22,16 +22,7 @@ function smarty_function_counter($params, &$smarty) { static $counters = array(); - extract($params); - - if (!isset($name)) { - if(isset($id)) { - $name = $id; - } else { - $name = "default"; - } - } - + $name = (isset($params['name'])) ? $params['name'] : 'default'; if (!isset($counters[$name])) { $counters[$name] = array( 'start'=>1, @@ -42,20 +33,20 @@ function smarty_function_counter($params, &$smarty) } $counter =& $counters[$name]; - if (isset($start)) { - $counter['start'] = $counter['count'] = $start; + if (isset($params['start'])) { + $counter['start'] = $counter['count'] = (int)$params['start']; } - if (!empty($assign)) { - $counter['assign'] = $assign; + if (!empty($params['assign'])) { + $counter['assign'] = $params['assign']; } if (isset($counter['assign'])) { $smarty->assign($counter['assign'], $counter['count']); } - if (isset($print)) { - $print = (bool)$print; + if (isset($params['print'])) { + $print = (bool)$params['print']; } else { $print = empty($counter['assign']); } @@ -66,12 +57,12 @@ function smarty_function_counter($params, &$smarty) $retval = null; } - if (isset($skip)) { - $counter['skip'] = $skip; + if (isset($params['skip'])) { + $counter['skip'] = $params['skip']; } - if (isset($direction)) { - $counter['direction'] = $direction; + if (isset($params['direction'])) { + $counter['direction'] = $params['direction']; } if ($counter['direction'] == "down") diff --git a/libs/plugins/function.cycle.php b/libs/plugins/function.cycle.php index d5909a61..1f4ec9e6 100644 --- a/libs/plugins/function.cycle.php +++ b/libs/plugins/function.cycle.php @@ -45,23 +45,10 @@ function smarty_function_cycle($params, &$smarty) { static $cycle_vars; - extract($params); - - if (empty($name)) { - $name = 'default'; - } - - if (!isset($print)) { - $print = true; - } - - if (!isset($advance)) { - $advance = true; - } - - if (!isset($reset)) { - $reset = false; - } + $name = (empty($params['name'])) ? 'default' : $params['name']; + $print = (isset($params['print'])) ? (bool)$params['print'] : true; + $advance = (isset($params['advance'])) ? (bool)$params['advance'] : true; + $reset = (isset($params['reset'])) ? (bool)$params['reset'] : false; if (!in_array('values', array_keys($params))) { if(!isset($cycle_vars[$name]['values'])) { @@ -70,31 +57,27 @@ function smarty_function_cycle($params, &$smarty) } } else { if(isset($cycle_vars[$name]['values']) - && $cycle_vars[$name]['values'] != $values ) { + && $cycle_vars[$name]['values'] != $params['values'] ) { $cycle_vars[$name]['index'] = 0; } - $cycle_vars[$name]['values'] = $values; + $cycle_vars[$name]['values'] = $params['values']; } - if (isset($delimiter)) { - $cycle_vars[$name]['delimiter'] = $delimiter; - } elseif (!isset($cycle_vars[$name]['delimiter'])) { - $cycle_vars[$name]['delimiter'] = ','; - } + $cycle_vars[$name]['delimiter'] = (isset($params['delimiter'])) ? $params['delimiter'] : ','; - if(!is_array($cycle_vars[$name]['values'])) { - $cycle_array = explode($cycle_vars[$name]['delimiter'],$cycle_vars[$name]['values']); - } else { + if(is_array($cycle_vars[$name]['values'])) { $cycle_array = $cycle_vars[$name]['values']; + } else { + $cycle_array = explode($cycle_vars[$name]['delimiter'],$cycle_vars[$name]['values']); } if(!isset($cycle_vars[$name]['index']) || $reset ) { $cycle_vars[$name]['index'] = 0; } - if (isset($assign)) { + if (isset($params['assign'])) { $print = false; - $smarty->assign($assign, $cycle_array[$cycle_vars[$name]['index']]); + $smarty->assign($params['assign'], $cycle_array[$cycle_vars[$name]['index']]); } if($print) {