smarty-php/smarty
1
0
Fork 0
mirror of https://github.com/smarty-php/smarty.git synced 2025-08-04 18:34:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

use tmp file for file writes, avoid race condition

Browse Source
This commit is contained in:
mohrt
2003-02-24 15:14:53 +00:00
parent 3e755114a3
commit f5f21995ef
2 changed files with 16 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
NEWS
View File

@@ -1,3 +1,4 @@
- use tmp file for file writes, avoid file lock race (Monte)
- handle embedded "$smarty.config.foo.tpl" correctly (Monte) - handle embedded "$smarty.config.foo.tpl" correctly (Monte)
- add $smarty.config.varname variable for accessing config vars (Paul - add $smarty.config.varname variable for accessing config vars (Paul
Lockaby, Monte) Lockaby, Monte)

27
libs/Smarty.class.php
View File

@@ -2041,22 +2041,25 @@ class Smarty
*/ */
function _write_file($filename, $contents, $create_dirs = false) function _write_file($filename, $contents, $create_dirs = false)
{ {
if ($create_dirs) $_dirname = dirname($filename);
$this->_create_dir_structure(dirname($filename));
if (!($fd = @fopen($filename, 'w'))) { if ($create_dirs) {
$this->trigger_error("problem writing '$filename.'"); $this->_create_dir_structure($_dirname);
}
// write to tmp file, then rename it to avoid
// file locking race condition
$_tmp_file = $_dirname . '/' . uniqid('');
if (!($fd = @fopen($_tmp_file, 'w'))) {
$this->trigger_error("problem writing temporary file '$_tmp_file'");
return false; return false;
} }
// flock doesn't seem to work on several windows platforms (98, NT4, NT5, ?), fwrite($fd, $contents);
// so we'll not use it at all in windows. fclose($fd);
rename($_tmp_file, $filename);
if ( strtoupper(substr(PHP_OS, 0, 3)) == 'WIN' || (flock($fd, LOCK_EX)) ) { chmod($filename, $this->_file_perms);
fwrite( $fd, $contents );
fclose($fd);
chmod($filename, $this->_file_perms);
}
return true; return true;
} }