wolfSSL/wolfssl
1
0
Fork 1
mirror of https://github.com/wolfSSL/wolfssl.git synced 2026-07-05 15:10:48 +02:00
Code Issues Packages Projects Releases Wiki Activity

parallel-make-check.py: only require bwrap for an actual netns run

Browse Source 
netns needs bwrap; without it commands silently share the host network
namespace and parallel network tests collide on ports. Skip the check for
--list (it inspects configs, runs nothing), hard-fail on CI so a missing-
bubblewrap misconfig can't silently degrade, and locally just warn and fall
back to the shared namespace.
This commit is contained in:
Juliusz Sosinowicz
2026-06-25 13:05:35 +00:00
parent f2fa741bad
commit 044a477378
1 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/scripts/parallel-make-check.py
+12 -4
View File
@@ -622,10 +622,18 @@ def main() -> int:
if dups:
p.error(f"config names collide after shard fan-out: {' '.join(dups)}")
if any(cfg.netns for cfg in selected) and not BWRAP:
p.error("netns requested but bwrap not found; install bubblewrap "
"(without it the commands share the host network namespace "
"and collide on ports)")
# netns needs bwrap; without it commands silently share the host network
# namespace and parallel network tests collide on ports. On CI that silent
# degradation is a misconfiguration, so fail loudly; locally just warn and
# let the run fall back to the shared namespace. --list needs neither bwrap
# nor a netns, so never block it.
if not opts.list and any(cfg.netns for cfg in selected) and not BWRAP:
msg = ("netns requested but bwrap not found; install bubblewrap "
"(without it commands share the host network namespace and "
"collide on ports)")
if ON_GITHUB:
p.error(msg)
warn(f"{msg}; falling back to the shared namespace")
if opts.list:
for cfg in selected: