wolfSSL/wolfssl
1
0
Fork 1
mirror of https://github.com/wolfSSL/wolfssl.git synced 2025-07-31 03:07:29 +02:00
Code Issues Packages Projects Releases Wiki Activity

wolfcrypt/src/rsa.c: fixes for cppcheck complaints: identicalInnerCondition

Browse Source
This commit is contained in:
Daniel Pouzzner
2022-01-08 00:32:03 -06:00
parent 24bb007d3c
commit 094d89bfb9
1 changed files with 19 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
wolfcrypt/src/rsa.c
View File

@ -2420,32 +2420,41 @@ static int wc_RsaFunctionSync(const byte* in, word32 inLen, byte* out,
#if defined(WC_RSA_BLINDING) && !defined(WC_NO_RNG) #if defined(WC_RSA_BLINDING) && !defined(WC_NO_RNG)
/* blind */ /* blind */
ret = mp_rand(rnd, get_digit_count(&key->n), rng); ret = mp_rand(rnd, get_digit_count(&key->n), rng);
if (ret != 0)
break;
/* rndi = 1/rnd mod n */ /* rndi = 1/rnd mod n */
if (ret == 0 && mp_invmod(rnd, &key->n, rndi) != MP_OKAY) if (mp_invmod(rnd, &key->n, rndi) != MP_OKAY) {
ret = MP_INVMOD_E; ret = MP_INVMOD_E;
break;
}
/* rnd = rnd^e */ /* rnd = rnd^e */
#ifndef WOLFSSL_SP_MATH_ALL #ifndef WOLFSSL_SP_MATH_ALL
if (ret == 0 && mp_exptmod(rnd, &key->e, &key->n, rnd) != MP_OKAY) if (mp_exptmod(rnd, &key->e, &key->n, rnd) != MP_OKAY) {
ret = MP_EXPTMOD_E; ret = MP_EXPTMOD_E;
break;
}
#else #else
if (ret == 0 && mp_exptmod_nct(rnd, &key->e, &key->n, if (mp_exptmod_nct(rnd, &key->e, &key->n, rnd) != MP_OKAY) {
rnd) != MP_OKAY) {
ret = MP_EXPTMOD_E; ret = MP_EXPTMOD_E;
break;
} }
#endif #endif
/* tmp = tmp*rnd mod n */ /* tmp = tmp*rnd mod n */
if (ret == 0 && mp_mulmod(tmp, rnd, &key->n, tmp) != MP_OKAY) if (mp_mulmod(tmp, rnd, &key->n, tmp) != MP_OKAY) {
ret = MP_MULMOD_E; ret = MP_MULMOD_E;
break;
}
#endif /* WC_RSA_BLINDING && !WC_NO_RNG */ #endif /* WC_RSA_BLINDING && !WC_NO_RNG */
#ifdef RSA_LOW_MEM /* half as much memory but twice as slow */ #ifdef RSA_LOW_MEM /* half as much memory but twice as slow */
if (ret == 0 && mp_exptmod(tmp, &key->d, &key->n, tmp) != MP_OKAY) if (mp_exptmod(tmp, &key->d, &key->n, tmp) != MP_OKAY) {
ret = MP_EXPTMOD_E; ret = MP_EXPTMOD_E;
break;
}
#else #else
if (ret == 0) { {
#ifdef WOLFSSL_SMALL_STACK #ifdef WOLFSSL_SMALL_STACK
mp_int* tmpa; mp_int* tmpa;
mp_int* tmpb = NULL; mp_int* tmpb = NULL;
@ -2461,9 +2470,9 @@ static int wc_RsaFunctionSync(const byte* in, word32 inLen, byte* out,
tmpb = tmpa + 1; tmpb = tmpa + 1;
else else
ret = MEMORY_E; ret = MEMORY_E;
if (ret == 0)
#endif #endif
{
if (ret == 0) {
if (mp_init(tmpa) != MP_OKAY) if (mp_init(tmpa) != MP_OKAY)
ret = MP_INIT_E; ret = MP_INIT_E;
else else