From 1103552c373264c4272eb8e4c72ca1b646452e37 Mon Sep 17 00:00:00 2001 From: Kareem Date: Thu, 22 Jan 2026 15:46:13 -0700 Subject: [PATCH] Code review feedback --- doc/dox_comments/header_files/ssl.h | 2 +- src/internal.c | 2 +- src/ssl.c | 2 +- wolfssl/ssl.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/dox_comments/header_files/ssl.h b/doc/dox_comments/header_files/ssl.h index c880e4eba..547f0077f 100644 --- a/doc/dox_comments/header_files/ssl.h +++ b/doc/dox_comments/header_files/ssl.h @@ -16018,7 +16018,7 @@ void wolfSSL_CTX_set_default_passwd_cb_userdata(WOLFSSL_CTX* ctx, \sa wolfSSL_set_scr_check_enabled */ -byte wolfSSL_get_scr_check_enabled(WOLFSSL* ssl); +int wolfSSL_get_scr_check_enabled(const WOLFSSL* ssl); /*! \ingroup Setup diff --git a/src/internal.c b/src/internal.c index 5587863e4..55a5a909a 100644 --- a/src/internal.c +++ b/src/internal.c @@ -18110,7 +18110,7 @@ int DoHandShakeMsgType(WOLFSSL* ssl, byte* input, word32* inOutIdx, #if !defined(HAVE_SECURE_RENEGOTIATION) if (ssl->options.handShakeState == HANDSHAKE_DONE && type == client_hello && - ssl->options.side == WOLFSSL_SERVER_END){ + ssl->options.side == WOLFSSL_SERVER_END) { WOLFSSL_MSG("Renegotiation request rejected"); SendAlert(ssl, alert_fatal, no_renegotiation); WOLFSSL_ERROR_VERBOSE(SECURE_RENEGOTIATION_E); diff --git a/src/ssl.c b/src/ssl.c index 8fc5833b9..d72c8ef9f 100644 --- a/src/ssl.c +++ b/src/ssl.c @@ -4222,7 +4222,7 @@ long wolfSSL_SSL_get_secure_renegotiation_support(WOLFSSL* ssl) #if !defined(NO_WOLFSSL_CLIENT) && !defined(WOLFSSL_NO_TLS12) && \ defined(WOLFSSL_HARDEN_TLS) && !defined(WOLFSSL_HARDEN_TLS_NO_SCR_CHECK) -WOLFSSL_API int wolfSSL_get_scr_check_enabled(WOLFSSL* ssl) +WOLFSSL_API int wolfSSL_get_scr_check_enabled(const WOLFSSL* ssl) { WOLFSSL_ENTER("wolfSSL_get_scr_check_enabled"); diff --git a/wolfssl/ssl.h b/wolfssl/ssl.h index 9c95b21cd..beb186936 100644 --- a/wolfssl/ssl.h +++ b/wolfssl/ssl.h @@ -4733,7 +4733,7 @@ WOLFSSL_API long wolfSSL_SSL_get_secure_renegotiation_support(WOLFSSL* ssl); #if !defined(NO_WOLFSSL_CLIENT) && !defined(WOLFSSL_NO_TLS12) && \ defined(WOLFSSL_HARDEN_TLS) && !defined(WOLFSSL_HARDEN_TLS_NO_SCR_CHECK) -WOLFSSL_API int wolfSSL_get_scr_check_enabled(WOLFSSL* ssl); +WOLFSSL_API int wolfSSL_get_scr_check_enabled(const WOLFSSL* ssl); WOLFSSL_API int wolfSSL_set_scr_check_enabled(WOLFSSL* ssl, byte enabled); #endif