Merge pull request #3880 from embhorn/cov_fixes

Fix resource leak
2025-08-01 19:54:40 +02:00 · 2021-03-18 15:18:38 -07:00
parent a363077b1e 36f80d53aa
commit 14e79a165a
1 changed files with 21 additions and 19 deletions
--- a/src/ocsp.c
+++ b/src/ocsp.c
@@ -624,9 +624,10 @@ WOLFSSL_OCSP_CERTID* wolfSSL_OCSP_cert_to_id(
        if (certStatus)
            XFREE(certStatus, NULL, DYNAMIC_TYPE_OPENSSL);

-        return NULL;
+        certId = NULL;
    }

+    if (certId != NULL) {
        XMEMSET(certId, 0, sizeof(WOLFSSL_OCSP_CERTID));
        XMEMSET(certStatus, 0, sizeof(CertStatus));

@@ -646,6 +647,7 @@ WOLFSSL_OCSP_CERTID* wolfSSL_OCSP_cert_to_id(
            certId->status->serialSz = cert.serialSz;
        }
        FreeDecodedCert(&cert);
+    }

    wolfSSL_CertManagerFree(cm);