wolfSSL/wolfssl
1
0
Fork 1
mirror of https://github.com/wolfSSL/wolfssl.git synced 2025-08-02 20:24:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #347 from dgarske/ScanBuildFix214

Browse Source 
Address scan-build issue on build #214 after DerBuffer refactor part 2
This commit is contained in:
JacobBarthelmeh
2016-03-11 16:53:41 -07:00
parent 98f40fa132 81b0ccdb1a
commit 154f027c54
1 changed files with 13 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/internal.c
View File

@@ -8879,7 +8879,7 @@ int SendCertificateStatus(WOLFSSL* ssl)
if (ret == 0 && (!ssl->ctx->chainOcspRequest[0] if (ret == 0 && (!ssl->ctx->chainOcspRequest[0]
|| ssl->buffers.weOwnCertChain)) { || ssl->buffers.weOwnCertChain)) {
DerBuffer* der = NULL; buffer der;
word32 idx = 0; word32 idx = 0;
#ifdef WOLFSSL_SMALL_STACK #ifdef WOLFSSL_SMALL_STACK
DecodedCert* cert = NULL; DecodedCert* cert = NULL;
@@ -8887,6 +8887,8 @@ int SendCertificateStatus(WOLFSSL* ssl)
DecodedCert cert[1]; DecodedCert cert[1];
#endif #endif
XMEMSET(&der, 0, sizeof(buffer));
#ifdef WOLFSSL_SMALL_STACK #ifdef WOLFSSL_SMALL_STACK
cert = (DecodedCert*)XMALLOC(sizeof(DecodedCert), NULL, cert = (DecodedCert*)XMALLOC(sizeof(DecodedCert), NULL,
DYNAMIC_TYPE_TMP_BUFFER); DYNAMIC_TYPE_TMP_BUFFER);
@@ -8895,16 +8897,16 @@ int SendCertificateStatus(WOLFSSL* ssl)
#endif #endif
while (idx + OPAQUE24_LEN < ssl->buffers.certChain->length) { while (idx + OPAQUE24_LEN < ssl->buffers.certChain->length) {
c24to32(ssl->buffers.certChain->buffer + idx, &der->length); c24to32(ssl->buffers.certChain->buffer + idx, &der.length);
idx += OPAQUE24_LEN; idx += OPAQUE24_LEN;
der->buffer = ssl->buffers.certChain->buffer + idx; der.buffer = ssl->buffers.certChain->buffer + idx;
idx += der->length; idx += der.length;
if (idx > ssl->buffers.certChain->length) if (idx > ssl->buffers.certChain->length)
break; break;
InitDecodedCert(cert, der->buffer, der->length, NULL); InitDecodedCert(cert, der.buffer, der.length, NULL);
if ((ret = ParseCertRelative(cert, CERT_TYPE, VERIFY, if ((ret = ParseCertRelative(cert, CERT_TYPE, VERIFY,
ssl->ctx->cm)) != 0) { ssl->ctx->cm)) != 0) {