From 1eb5537e346c68bffe8bb972d2679ed2b5594d5a Mon Sep 17 00:00:00 2001 From: Daniel Pouzzner Date: Sat, 8 Jan 2022 00:30:00 -0600 Subject: [PATCH] wolfcrypt/src/fe_low_mem.c: fixes for cppcheck complaints: funcArgOrderDifferent --- wolfcrypt/src/fe_low_mem.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/wolfcrypt/src/fe_low_mem.c b/wolfcrypt/src/fe_low_mem.c index 45c1b7abb..2eb512f4c 100644 --- a/wolfcrypt/src/fe_low_mem.c +++ b/wolfcrypt/src/fe_low_mem.c @@ -141,7 +141,7 @@ static void xc_diffadd(byte *x5, byte *z5, } #ifndef FREESCALE_LTC_ECC -int curve25519(byte *result, const byte *e, const byte *q) +int curve25519(byte *result, const byte *n, const byte *p) { /* Current point: P_m */ byte xm[F25519_SIZE]; @@ -154,19 +154,19 @@ int curve25519(byte *result, const byte *e, const byte *q) int i; /* Note: bit 254 is assumed to be 1 */ - lm_copy(xm, q); + lm_copy(xm, p); for (i = 253; i >= 0; i--) { - const int bit = (e[i >> 3] >> (i & 7)) & 1; + const int bit = (n[i >> 3] >> (i & 7)) & 1; byte xms[F25519_SIZE]; byte zms[F25519_SIZE]; /* From P_m and P_(m-1), compute P_(2m) and P_(2m-1) */ - xc_diffadd(xm1, zm1, q, f25519_one, xm, zm, xm1, zm1); + xc_diffadd(xm1, zm1, p, f25519_one, xm, zm, xm1, zm1); xc_double(xm, zm, xm, zm); /* Compute P_(2m+1) */ - xc_diffadd(xms, zms, xm1, zm1, xm, zm, q, f25519_one); + xc_diffadd(xms, zms, xm1, zm1, xm, zm, p, f25519_one); /* Select: * bit = 1 --> (P_(2m+1), P_(2m))