wolfSSL/wolfssl
1
0
Fork 1
mirror of https://github.com/wolfSSL/wolfssl.git synced 2025-07-30 18:57:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

wc_DsaSign(): removal several redundant mp_clear()s preceded by mp_forcezero()s.

Browse Source
This commit is contained in:
Daniel Pouzzner
2020-12-07 13:42:43 -06:00
parent bfff28ab28
commit 2ed75402b8
1 changed files with 3 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
wolfcrypt/src/dsa.c
View File

@ -907,17 +907,13 @@ int wc_DsaSign(const byte* digest, byte* out, DsaKey* key, WC_RNG* rng)
#ifdef WOLFSSL_SMALL_STACK #ifdef WOLFSSL_SMALL_STACK
if (k) { if (k) {
if (ret != MP_INIT_E) { if (ret != MP_INIT_E)
mp_forcezero(k); mp_forcezero(k);
mp_clear(k);
}
XFREE(k, key->heap, DYNAMIC_TYPE_TMP_BUFFER); XFREE(k, key->heap, DYNAMIC_TYPE_TMP_BUFFER);
} }
if (kInv) { if (kInv) {
if (ret != MP_INIT_E) { if (ret != MP_INIT_E)
mp_forcezero(kInv); mp_forcezero(kInv);
mp_clear(kInv);
}
XFREE(kInv, key->heap, DYNAMIC_TYPE_TMP_BUFFER); XFREE(kInv, key->heap, DYNAMIC_TYPE_TMP_BUFFER);
} }
if (r) { if (r) {
@ -937,10 +933,8 @@ int wc_DsaSign(const byte* digest, byte* out, DsaKey* key, WC_RNG* rng)
} }
#ifndef WOLFSSL_MP_INVMOD_CONSTANT_TIME #ifndef WOLFSSL_MP_INVMOD_CONSTANT_TIME
if (b) { if (b) {
if (ret != MP_INIT_E) { if (ret != MP_INIT_E)
mp_forcezero(b); mp_forcezero(b);
mp_clear(b);
}
XFREE(b, key->heap, DYNAMIC_TYPE_TMP_BUFFER); XFREE(b, key->heap, DYNAMIC_TYPE_TMP_BUFFER);
} }
#endif #endif
@ -955,13 +949,10 @@ int wc_DsaSign(const byte* digest, byte* out, DsaKey* key, WC_RNG* rng)
mp_forcezero(k); mp_forcezero(k);
#ifndef WOLFSSL_MP_INVMOD_CONSTANT_TIME #ifndef WOLFSSL_MP_INVMOD_CONSTANT_TIME
mp_forcezero(b); mp_forcezero(b);
mp_clear(b);
#endif #endif
mp_clear(H); mp_clear(H);
mp_clear(s); mp_clear(s);
mp_clear(r); mp_clear(r);
mp_clear(kInv);
mp_clear(k);
} }
#endif #endif