From 325ee2c2743e3436958271cff128963c3cd7ceee Mon Sep 17 00:00:00 2001 From: kaleb-himes Date: Fri, 6 Mar 2026 10:38:02 -0700 Subject: [PATCH] Implement peer review feedback --- scripts/openssl.test | 23 ++--------------------- 1 file changed, 2 insertions(+), 21 deletions(-) diff --git a/scripts/openssl.test b/scripts/openssl.test index 45859fbe1d..b41d4499af 100755 --- a/scripts/openssl.test +++ b/scripts/openssl.test @@ -160,18 +160,6 @@ do_trap() { trap do_trap INT TERM - -check_process_running() { - if [ "$ps_grep" = "" ] - then - ps -p "$server_pid" > /dev/null - PS_EXIT=$? - else - pgrep -f "^ *$server_pid " > /dev/null - PS_EXIT=$? - fi -} - # # Start an OpenSSL server # @@ -218,8 +206,7 @@ start_openssl_server() { # wait to see if s_server successfully starts before continuing sleep 0.1 - check_process_running - if [ "$PS_EXIT" = "0" ] + if kill -0 "$server_pid" 2>/dev/null then echo "s_server started successfully on port $server_port" found_free_port=1 @@ -283,8 +270,7 @@ start_wolfssl_server() { # wait to see if server successfully starts before continuing sleep 0.1 - check_process_running - if [ "$PS_EXIT" = "0" ] + if kill -0 "$server_pid" 2>/dev/null then echo "wolfSSL server started successfully on port $server_port" found_free_port=1 @@ -463,11 +449,6 @@ echo "OpenSSL version:" $OPENSSL version -a echo -if ! ps -p $PPID >/dev/null 2>&1; then - ps_grep="yes" - echo "ps -p not working, using ps and grep" -fi - echo -e "\nTesting existence of openssl command...\n" command -v "$OPENSSL" >/dev/null 2>&1 || { echo >&2 "Requires openssl command, but it's not installed. Ending."; do_cleanup; exit 0; }