wolfSSL/wolfssl
1
0
Fork 1
mirror of https://github.com/wolfSSL/wolfssl.git synced 2026-01-30 06:22:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2464 from SparkiDev/rshift_neg

Browse Source 
Use constant time comparison in MaskMac with scanStart and macStart
This commit is contained in:
toddouska
2019-09-13 11:56:12 -07:00
committed by GitHub
parent a2d3da2831 2a1a9f36cc
commit 40fc86dfd2
3 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/internal.c
View File

@@ -13241,8 +13241,8 @@ static byte MaskMac(const byte* data, int sz, int macSz, byte* expMac)
unsigned char started, notEnded;
unsigned char good = 0;
scanStart &= (~scanStart) >> (sizeof(int) * 8 - 1);
macStart &= (~macStart) >> (sizeof(int) * 8 - 1);
scanStart &= ctMaskIntGTE(scanStart, 0);
macStart &= ctMaskIntGTE(macStart, 0);
/* Div on Intel has different speeds depending on value.
* Use a bitwise AND or mod a specific value (converted to mul). */