From 429b690370f577ce720e535d6bc8fcc3e60970ba Mon Sep 17 00:00:00 2001 From: Juliusz Sosinowicz Date: Mon, 19 Jan 2026 09:38:17 +0100 Subject: [PATCH] Address code review --- src/dtls13.c | 2 +- tests/api/test_dtls.c | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/dtls13.c b/src/dtls13.c index bd4d72247..d3d5ee624 100644 --- a/src/dtls13.c +++ b/src/dtls13.c @@ -111,7 +111,7 @@ typedef struct Dtls13RecordPlaintextHeader { #define DTLS13_UNIFIED_HEADER_SIZE 5 #define DTLS13_MIN_CIPHERTEXT 16 #ifndef DTLS13_MIN_RTX_INTERVAL -#define DTLS13_MIN_RTX_INTERVAL 1000 +#define DTLS13_MIN_RTX_INTERVAL (DTLS_TIMEOUT_INIT * 1000) #endif #ifndef NO_WOLFSSL_CLIENT diff --git a/tests/api/test_dtls.c b/tests/api/test_dtls.c index e93816dcf..a1f592c70 100644 --- a/tests/api/test_dtls.c +++ b/tests/api/test_dtls.c @@ -2493,6 +2493,8 @@ int test_dtls_mtu_split_messages(void) /* Test DTLS 1.3 minimum retransmission interval. This test calls * wolfSSL_dtls_got_timeout() to simulate timeouts and verify that * retransmissions are spaced at least DTLS13_MIN_RTX_INTERVAL apart. + * This tests relies on timing of the retransmission logic so it may be + * flaky on very slow systems. */ int test_dtls13_min_rtx_interval(void) { @@ -2541,7 +2543,8 @@ int test_dtls13_min_rtx_interval(void) ExpectIntEQ(wolfSSL_dtls_got_timeout(ssl_s), WOLFSSL_SUCCESS); ExpectIntEQ(wolfSSL_dtls_got_timeout(ssl_s), WOLFSSL_SUCCESS); /* Save the message count to make sure no new messages are sent */ - ExpectIntGE(c_msg_count = test_ctx.c_msg_count, 2); + ExpectIntGE(test_ctx.c_msg_count, 2); + c_msg_count = test_ctx.c_msg_count; /* Second timeout. This one should not trigger a retransmission */ if (wolfSSL_dtls13_use_quick_timeout(ssl_s))