wolfSSL/wolfssl
1
0
Fork 1
mirror of https://github.com/wolfSSL/wolfssl.git synced 2025-07-30 10:47:28 +02:00
Code Issues Packages Projects Releases Wiki Activity

fixed compile error due to degression

Browse Source 
fixed memory leak in wc_SCE_EccVerify
This commit is contained in:
Hideki Miyazaki
2022-07-22 08:29:05 +09:00
parent 9a3efb67b8
commit 491ebb7a3d
2 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
wolfcrypt/src/port/Renesas/renesas_common.c
View File

@ -25,8 +25,12 @@
#if defined(WOLFSSL_RENESAS_SCEPROTECT) #if defined(WOLFSSL_RENESAS_SCEPROTECT)
#include <wolfssl/wolfcrypt/port/Renesas/renesas-sce-crypt.h> #include <wolfssl/wolfcrypt/port/Renesas/renesas-sce-crypt.h>
#define cmn_hw_lock wc_sce_hw_lock
#define cmn_hw_unlock wc_sce_hw_unlock
#elif defined(WOLFSSL_RENESAS_TSIP_TLS) #elif defined(WOLFSSL_RENESAS_TSIP_TLS)
#include <wolfssl/wolfcrypt/port/Renesas/renesas-tsip-crypt.h> #include <wolfssl/wolfcrypt/port/Renesas/renesas-tsip-crypt.h>
#define cmn_hw_lock tsip_hw_lock
#define cmn_hw_unlock tsip_hw_unlock
#endif #endif
#include <wolfssl/wolfcrypt/wc_port.h> #include <wolfssl/wolfcrypt/wc_port.h>
@ -371,9 +375,9 @@ int wc_CryptoCb_CryptInitRenesasCmn(WOLFSSL* ssl, void* ctx)
return INVALID_DEVID; return INVALID_DEVID;
} }
/* need exclusive control because of static variable */ /* need exclusive control because of static variable */
if ((tsip_hw_lock()) == 0) { if ((cmn_hw_lock()) == 0) {
cbInfo->devId = gdevId++; cbInfo->devId = gdevId++;
tsip_hw_unlock(); cmn_hw_unlock();
} }
else { else {
WOLFSSL_MSG("Failed to lock tsip hw"); WOLFSSL_MSG("Failed to lock tsip hw");
@ -669,7 +673,7 @@ WOLFSSL_LOCAL int Renesas_cmn_generateSessionKey(WOLFSSL* ssl, void* ctx)
#if defined(WOLFSSL_RENESAS_TSIP_TLS) #if defined(WOLFSSL_RENESAS_TSIP_TLS)
ret = wc_tsip_generateSessionKey(ssl, (TsipUserCtx*)ctx, cbInfo->devId); ret = wc_tsip_generateSessionKey(ssl, (TsipUserCtx*)ctx, cbInfo->devId);
#elif defined(WOLFSSL_RENESAS_SCEPROTECT) #elif defined(WOLFSSL_RENESAS_SCEPROTECT)
ret = wc_sce_generateSessionKey(ssl, ctx, devId); ret = wc_sce_generateSessionKey(ssl, ctx, cbInfo->devId);
#endif #endif
} }
else { else {

7
wolfcrypt/src/port/Renesas/renesas_sce_util.c
View File

@ -267,7 +267,6 @@ WOLFSSL_LOCAL int wc_SCE_EccVerify(WOLFSSL* ssl, const uint8_t* sig,
{ {
int ret = WOLFSSL_FAILURE; int ret = WOLFSSL_FAILURE;
uint8_t *sigforSCE; uint8_t *sigforSCE;
uint8_t *pSig;
const byte rs_size = HW_SCE_ECDSA_DATA_BYTE_SIZE/2; const byte rs_size = HW_SCE_ECDSA_DATA_BYTE_SIZE/2;
byte offset = 0x3; byte offset = 0x3;
(void) sigSz; (void) sigSz;
@ -277,7 +276,6 @@ WOLFSSL_LOCAL int wc_SCE_EccVerify(WOLFSSL* ssl, const uint8_t* sig,
(void) keySz; (void) keySz;
sigforSCE = NULL; sigforSCE = NULL;
pSig = NULL;
WOLFSSL_PKMSG("SCE ECC Verify: ssl->options.serverState = %d sigSz %d, hashSz %d, keySz %d\n", WOLFSSL_PKMSG("SCE ECC Verify: ssl->options.serverState = %d sigSz %d, hashSz %d, keySz %d\n",
ssl->options.serverState, sigSz, hashSz, keySz); ssl->options.serverState, sigSz, hashSz, keySz);
@ -321,9 +319,10 @@ WOLFSSL_LOCAL int wc_SCE_EccVerify(WOLFSSL* ssl, const uint8_t* sig,
} }
} }
pSig = sigforSCE; ret = SCE_ServerKeyExVerify(2, ssl, sigforSCE, 64, ctx);
ret = SCE_ServerKeyExVerify(2, ssl, pSig, 64, ctx); if (sigforSCE)
XFREE(sigforSCE, NULL, DYNAMIC_TYPE_TEMP);
if (ret == WOLFSSL_SUCCESS) { if (ret == WOLFSSL_SUCCESS) {
*result = 1; *result = 1;