Fix code review suggestion.

This commit is contained in:
Go Hosohara
2017-07-11 09:06:48 +09:00
committed by Jacob Barthelmeh
parent 0edd97293d
commit 4b13a0f301
2 changed files with 3 additions and 8 deletions

View File

@@ -15145,7 +15145,6 @@ static void ExternalFreeX509(WOLFSSL_X509* x509)
/* these index values are already stored in DecodedName /* these index values are already stored in DecodedName
use those when available */ use those when available */
if (name->fullName.fullName && name->fullName.fullNameLen > 0) { if (name->fullName.fullName && name->fullName.fullNameLen > 0) {
printf("NID = %x\n",nid);
switch (nid) { switch (nid) {
case ASN_COMMON_NAME: case ASN_COMMON_NAME:
if (pos != name->fullName.cnIdx) if (pos != name->fullName.cnIdx)
@@ -15154,9 +15153,6 @@ static void ExternalFreeX509(WOLFSSL_X509* x509)
case ASN_DOMAIN_COMPONENT: case ASN_DOMAIN_COMPONENT:
if (pos != name->fullName.dcIdx) if (pos != name->fullName.dcIdx)
ret = name->fullName.dcIdx; ret = name->fullName.dcIdx;
printf("domain_component = %s\n",name->fullName.fullName + name->fullName.dcIdx);
printf("domain_component Idx = %d\n",name->fullName.dcIdx);
printf("domain_component Len = %d\n",name->fullName.dcLen);
break; break;
default: default:
WOLFSSL_MSG("NID not yet implemented"); WOLFSSL_MSG("NID not yet implemented");
@@ -19079,7 +19075,6 @@ const char* wolfSSL_alert_desc_string_long(int alertID)
*/ */
const char* wolfSSL_state_string_long(const WOLFSSL* ssl) const char* wolfSSL_state_string_long(const WOLFSSL* ssl)
{ {
WOLFSSL_ENTER("wolfSSL_state_string_long");
static const char* OUTPUT_STR[11][6][3] = { static const char* OUTPUT_STR[11][6][3] = {
{ {
@@ -19299,12 +19294,13 @@ const char* wolfSSL_state_string_long(const WOLFSSL* ssl)
TLS_V1_2, TLS_V1_2,
DTLS_V1, DTLS_V1,
DTLS_V1_2, DTLS_V1_2,
UNKNOWN UNKNOWN = 100
}; };
int state_type = 0; int state_type = 0;
int node_type = 0; int node_type = 0;
const int UNKNOWN_END = 2; const int UNKNOWN_END = 2;
WOLFSSL_ENTER("wolfSSL_state_string_long");
if (ssl == NULL) { if (ssl == NULL) {
WOLFSSL_MSG("Null argument passed in"); WOLFSSL_MSG("Null argument passed in");
return NULL; return NULL;
@@ -29475,7 +29471,6 @@ void* wolfSSL_GetDhAgreeCtx(WOLFSSL* ssl)
name->cnEntry.set = 1; name->cnEntry.set = 1;
return &(name->cnEntry); return &(name->cnEntry);
} else if (loc == name->fullName.dcIdx){ } else if (loc == name->fullName.dcIdx){
printf("domain = %s\n",name->x509->subjectCN);
name->cnEntry.data.data = name->x509->subjectCN; name->cnEntry.data.data = name->x509->subjectCN;
name->cnEntry.data.length = name->fullName.dcLen; name->cnEntry.data.length = name->fullName.dcLen;
name->cnEntry.data.type = CTC_UTF8; name->cnEntry.data.type = CTC_UTF8;

View File

@@ -1756,7 +1756,7 @@ WOLFSSL_API int wolfSSL_SetTlsHmacInner(WOLFSSL*, unsigned char
enum { enum {
WOLFSSL_SERVER_END = 0, WOLFSSL_SERVER_END = 0,
WOLFSSL_CLIENT_END = 1, WOLFSSL_CLIENT_END = 1,
WOLFSSL_NEITHER_END = 3, WOLFSSL_NEITHER_END = 2,
WOLFSSL_BLOCK_TYPE = 2, WOLFSSL_BLOCK_TYPE = 2,
WOLFSSL_STREAM_TYPE = 3, WOLFSSL_STREAM_TYPE = 3,
WOLFSSL_AEAD_TYPE = 4, WOLFSSL_AEAD_TYPE = 4,