wolfSSL/wolfssl
1
0
Fork 1
mirror of https://github.com/wolfSSL/wolfssl.git synced 2025-07-30 10:47:28 +02:00
Code Issues Packages Projects Releases Wiki Activity

CID 426426 code maintainability warning, stored NULL value overwritten before used

Browse Source
This commit is contained in:
JacobBarthelmeh
2024-10-23 18:05:12 -06:00
parent 077b070132
commit 52ba700eb3
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/x509_str.c
View File

@ -1754,7 +1754,7 @@ WOLF_STACK_OF(WOLFSSL_X509_OBJECT)* wolfSSL_X509_STORE_get0_objects(
* simplify cleanup logic handling cert merging above */ * simplify cleanup logic handling cert merging above */
for (i = 0; i < wolfSSL_sk_X509_num(cert_stack); i++) { for (i = 0; i < wolfSSL_sk_X509_num(cert_stack); i++) {
x509 = (WOLFSSL_X509 *)wolfSSL_sk_value(cert_stack, i); x509 = (WOLFSSL_X509 *)wolfSSL_sk_value(cert_stack, i);
obj = wolfSSL_X509_OBJECT_new(); obj = wolfSSL_X509_OBJECT_new();
if (obj == NULL) { if (obj == NULL) {
WOLFSSL_MSG("wolfSSL_X509_OBJECT_new error"); WOLFSSL_MSG("wolfSSL_X509_OBJECT_new error");
goto err_cleanup; goto err_cleanup;
@ -1766,10 +1766,9 @@ WOLF_STACK_OF(WOLFSSL_X509_OBJECT)* wolfSSL_X509_STORE_get0_objects(
} }
obj->type = WOLFSSL_X509_LU_X509; obj->type = WOLFSSL_X509_LU_X509;
obj->data.x509 = x509; obj->data.x509 = x509;
x509 = NULL;
} }
while(wolfSSL_sk_X509_num(cert_stack) > 0) { while (wolfSSL_sk_X509_num(cert_stack) > 0) {
wolfSSL_sk_X509_pop(cert_stack); wolfSSL_sk_X509_pop(cert_stack);
} }
#endif #endif
@ -1799,7 +1798,7 @@ err_cleanup:
if (ret != NULL) if (ret != NULL)
X509StoreFreeObjList(store, ret); X509StoreFreeObjList(store, ret);
if (cert_stack != NULL) { if (cert_stack != NULL) {
while(store->numAdded > 0) { while (store->numAdded > 0) {
wolfSSL_sk_X509_pop(cert_stack); wolfSSL_sk_X509_pop(cert_stack);
store->numAdded--; store->numAdded--;
} }