From 53ae8651846a2b75f195885de211bdd0b09d290b Mon Sep 17 00:00:00 2001 From: Hideki Miyazaki Date: Wed, 6 Aug 2025 19:13:20 +0900 Subject: [PATCH] Addressed code review --- IDE/Renesas/e2studio/RZN2L/test/src/rzn2l_tst_thread_entry.c | 3 +-- .../e2studio/RZN2L/test/src/test/wolfssl_rsip_unit_test.c | 4 +--- wolfcrypt/src/port/Renesas/renesas_common.c | 2 +- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/IDE/Renesas/e2studio/RZN2L/test/src/rzn2l_tst_thread_entry.c b/IDE/Renesas/e2studio/RZN2L/test/src/rzn2l_tst_thread_entry.c index c96569b94..ee2a86061 100644 --- a/IDE/Renesas/e2studio/RZN2L/test/src/rzn2l_tst_thread_entry.c +++ b/IDE/Renesas/e2studio/RZN2L/test/src/rzn2l_tst_thread_entry.c @@ -375,7 +375,6 @@ void rzn2l_tst_thread_entry(void *pvParameters) TCPInit(); int TCP_connect_retry = 0; - printf("\n"); printf("Start TLS Connection to %s port(%d)\n", SERVER_IP, DEFAULT_PORT); wolfSSL_TLS_client_init(); @@ -410,7 +409,7 @@ void rzn2l_tst_thread_entry(void *pvParameters) int TCP_connect_retry = 0; - printf("\n Start TLS Accept at %03d.%03d.%03d.%03d port(%d)\n", + printf("Start TLS Accept at %03d.%03d.%03d.%03d port(%d)\n", ucIPAddress[0], ucIPAddress[1], ucIPAddress[2], diff --git a/IDE/Renesas/e2studio/RZN2L/test/src/test/wolfssl_rsip_unit_test.c b/IDE/Renesas/e2studio/RZN2L/test/src/test/wolfssl_rsip_unit_test.c index 7f13443d7..5bf45499f 100644 --- a/IDE/Renesas/e2studio/RZN2L/test/src/test/wolfssl_rsip_unit_test.c +++ b/IDE/Renesas/e2studio/RZN2L/test/src/test/wolfssl_rsip_unit_test.c @@ -732,12 +732,10 @@ static int rsip_rsa_SignVerify_test(int prnt, int keySize, int devId) RsaKey *key = (RsaKey *)XMALLOC(sizeof *key, NULL, DYNAMIC_TYPE_TMP_BUFFER); WC_RNG rng; - word32 sigSz; const char inStr [] = TEST_STRING; const char inStr2[] = TEST_STRING2; const word32 inLen = (word32)TEST_STRING_SZ; const word32 outSz = RSA_TEST_BYTES; - (void)sigSz; byte *in = NULL; byte *in2 = NULL; @@ -781,7 +779,7 @@ static int rsip_rsa_SignVerify_test(int prnt, int keySize, int devId) if (ret < 0) { goto out; } - sigSz = (word32)ret; + //* this should fail */ ret = wc_RsaSSL_Verify(in2, inLen, out, (word32)(keySize/8), key); if (ret != FSP_ERR_CRYPTO_RSIP_FAIL) { diff --git a/wolfcrypt/src/port/Renesas/renesas_common.c b/wolfcrypt/src/port/Renesas/renesas_common.c index a351261ce..cf325ceca 100644 --- a/wolfcrypt/src/port/Renesas/renesas_common.c +++ b/wolfcrypt/src/port/Renesas/renesas_common.c @@ -430,7 +430,7 @@ int wc_CryptoCb_CryptInitRenesasCmn(struct WOLFSSL* ssl, void* ctx) * first. On that time, internal instance has not yet been allocated. */ if (cbInfo->internal == NULL) { - if (!ssl) + if (ssl) cbInfo->internal = (FSPSM_ST_Internal*)XMALLOC(internal_sz, ssl->heap, DYNAMIC_TYPE_TMP_BUFFER);