wolfSSL/wolfssl
1
0
Fork 1
mirror of https://github.com/wolfSSL/wolfssl.git synced 2025-08-02 04:04:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

place buffer on stack instead and zero it when done

Browse Source
This commit is contained in:
Jacob Barthelmeh
2018-01-10 13:36:03 -07:00
parent 0bfa399b6c
commit 59b9ab9097
1 changed files with 3 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
wolfcrypt/src/asn.c
View File

@@ -1804,8 +1804,8 @@ int wc_CheckPrivateKey(byte* key, word32 keySz, DecodedCert* der)
#ifdef HAVE_ECC #ifdef HAVE_ECC
if (der->keyOID == ECDSAk) { if (der->keyOID == ECDSAk) {
ecc_key key_pair; ecc_key key_pair;
byte* privDer; byte privDer[MAX_ECC_BYTES];
word32 privSz; word32 privSz = MAX_ECC_BYTES;
word32 keyIdx = 0; word32 keyIdx = 0;
if ((ret = wc_ecc_init(&key_pair)) < 0) if ((ret = wc_ecc_init(&key_pair)) < 0)
@@ -1815,15 +1815,6 @@ int wc_CheckPrivateKey(byte* key, word32 keySz, DecodedCert* der)
keySz)) == 0) { keySz)) == 0) {
WOLFSSL_MSG("Checking ECC key pair"); WOLFSSL_MSG("Checking ECC key pair");
if ((privSz = wc_ecc_size(&key_pair)) <= 0) {
return WC_KEY_SIZE_E;
}
privDer = (byte*)XMALLOC(privSz, der->heap, DYNAMIC_TYPE_KEY);
if (privDer == NULL) {
return MEMORY_E;
}
if ((ret = wc_ecc_export_private_only(&key_pair, privDer, &privSz)) if ((ret = wc_ecc_export_private_only(&key_pair, privDer, &privSz))
== 0) { == 0) {
wc_ecc_free(&key_pair); wc_ecc_free(&key_pair);
@@ -1842,9 +1833,8 @@ int wc_CheckPrivateKey(byte* key, word32 keySz, DecodedCert* der)
ret = 1; ret = 1;
} }
} }
ForceZero(privDer, privSz);
} }
XFREE(privDer, der->heap, DYNAMIC_TYPE_KEY);
} }
wc_ecc_free(&key_pair); wc_ecc_free(&key_pair);
} }