wolfSSL/wolfssl
1
0
Fork 1
mirror of https://github.com/wolfSSL/wolfssl.git synced 2025-07-30 18:57:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

Peer review feedback.

Browse Source
This commit is contained in:
David Garske
2022-03-30 15:38:30 -07:00
parent c905c613e9
commit 61f6b5e29c
2 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/api.c
View File

@ -39017,7 +39017,7 @@ static void test_wolfSSL_BIO_tls(void)
SSL *ssl; SSL *ssl;
BIO *readBio; BIO *readBio;
BIO *writeBio; BIO *writeBio;
int ret, err; int ret, err = 0;
AssertNotNull(ctx = SSL_CTX_new(SSLv23_method())); AssertNotNull(ctx = SSL_CTX_new(SSLv23_method()));
AssertNotNull(ssl = SSL_new(ctx)); AssertNotNull(ssl = SSL_new(ctx));

7
wolfcrypt/src/ecc.c
View File

@ -4788,7 +4788,7 @@ static WC_INLINE void wc_ecc_reset(ecc_key* key)
* ecc_curve_spec. Having this argument allows for not having to load the * ecc_curve_spec. Having this argument allows for not having to load the
* curve type multiple times when generating a key with wc_ecc_make_key(). * curve type multiple times when generating a key with wc_ecc_make_key().
* For async the results are placed directly into pubOut, so this function * For async the results are placed directly into pubOut, so this function
* does not need called again * does not need to be called again
* *
* returns MP_OKAY on success * returns MP_OKAY on success
*/ */
@ -4797,10 +4797,6 @@ static int ecc_make_pub_ex(ecc_key* key, ecc_curve_spec* curveIn,
{ {
int err = MP_OKAY; int err = MP_OKAY;
#ifdef HAVE_ECC_MAKE_PUB #ifdef HAVE_ECC_MAKE_PUB
#if !defined(WOLFSSL_SP_MATH) && !(defined(WOLFSSL_ASYNC_CRYPT) && \
defined(WC_ASYNC_ENABLE_ECC) && defined(HAVE_INTEL_QA))
ecc_point* base = NULL;
#endif
ecc_point* pub; ecc_point* pub;
DECLARE_CURVE_SPECS(ECC_CURVE_FIELD_COUNT); DECLARE_CURVE_SPECS(ECC_CURVE_FIELD_COUNT);
#endif /* HAVE_ECC_MAKE_PUB */ #endif /* HAVE_ECC_MAKE_PUB */
@ -4903,6 +4899,7 @@ static int ecc_make_pub_ex(ecc_key* key, ecc_curve_spec* curveIn,
#else #else
if (err == MP_OKAY) { if (err == MP_OKAY) {
mp_digit mp = 0; mp_digit mp = 0;
ecc_point* base = NULL;
#ifdef WOLFSSL_NO_MALLOC #ifdef WOLFSSL_NO_MALLOC
ecc_point lcl_base; ecc_point lcl_base;
base = &lcl_base; base = &lcl_base;