wolfSSL/wolfssl
1
0
Fork 1
mirror of https://github.com/wolfSSL/wolfssl.git synced 2025-07-30 18:57:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

BN API: fix BN_bin2bn to handle NULL data properly

Browse Source 
BN_bin2bn was freeing the BN and returning it.
Added test for this.
This commit is contained in:
Sean Parkinson
2024-10-16 14:08:55 +10:00
parent 0f8b4dbc63
commit 64a9e6f7c4
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/ssl_bn.c
View File

@ -516,12 +516,14 @@ WOLFSSL_BIGNUM* wolfSSL_BN_bin2bn(const unsigned char* data, int len,
ret = NULL;
}
else {
/* Don't free bn as we may be returning it. */
/* Don't free bn as we are returning it. */
bn = NULL;
}
}
else if (data == NULL) {
wolfSSL_BN_zero(ret);
/* Don't free bn as we are returning it. */
bn = NULL;
}
}

5
tests/api.c
View File

@ -61606,6 +61606,11 @@ static int test_wolfSSL_BN_enc_dec(void)
ExpectNull(BN_bn2dec(NULL));
ExpectNull(BN_bn2dec(&emptyBN));
ExpectNotNull(c = BN_bin2bn(NULL, 0, NULL));
BN_clear(c);
BN_free(c);
c = NULL;
ExpectNotNull(BN_bin2bn(NULL, sizeof(binNum), a));
BN_free(a);
ExpectNotNull(a = BN_new());