From 6c131e3e8b81c9e78390c8d37f887c1cd2599a9f Mon Sep 17 00:00:00 2001 From: David Garske Date: Thu, 6 May 2021 14:46:35 -0700 Subject: [PATCH] Fix off by 1 in rollover calculation. --- src/tls.c | 2 +- src/tls13.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/tls.c b/src/tls.c index 6a076bf79..b4f43b073 100644 --- a/src/tls.c +++ b/src/tls.c @@ -10375,7 +10375,7 @@ int TLSX_PopulateExtensions(WOLFSSL* ssl, byte isServer) return ret; now = TimeNowInMilliseconds(); if (now < sess->ticketSeen) - milli = (0xFFFFFFFFU - sess->ticketSeen) + now; + milli = (0xFFFFFFFFU - sess->ticketSeen) + 1 + now; else milli = now - sess->ticketSeen; milli += sess->ticketAdd; diff --git a/src/tls13.c b/src/tls13.c index 7f9288c4f..daff56177 100644 --- a/src/tls13.c +++ b/src/tls13.c @@ -3548,7 +3548,7 @@ static int DoPreSharedKeys(WOLFSSL* ssl, const byte* input, word32 helloSz, if (now == (word32)GETTIME_ERROR) return now; if (now < ssl->session.ticketSeen) - diff = (0xFFFFFFFFU - ssl->session.ticketSeen) + now; + diff = (0xFFFFFFFFU - ssl->session.ticketSeen) + 1 + now; else diff = now - ssl->session.ticketSeen; diff -= current->ticketAge - ssl->session.ticketAdd;