wolfSSL/wolfssl
1
0
Fork 1
mirror of https://github.com/wolfSSL/wolfssl.git synced 2025-07-30 10:47:28 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fixes for a few wolfCrypt test memory leaks. Fix for HMAC with empty input not supported on QuickAssist.

Browse Source
This commit is contained in:
David Garske
2018-06-20 14:51:32 -07:00
parent ec132cd3f4
commit 71606dde45
1 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
wolfcrypt/test/test.c
View File

@ -1502,6 +1502,8 @@ int md5_test(void)
if (ret != 0) if (ret != 0)
ERROR_OUT(-1605 - i, exit); ERROR_OUT(-1605 - i, exit);
wc_Md5Free(&md5Copy);
if (XMEMCMP(hash, test_md5[i].output, WC_MD5_DIGEST_SIZE) != 0) if (XMEMCMP(hash, test_md5[i].output, WC_MD5_DIGEST_SIZE) != 0)
ERROR_OUT(-1606 - i, exit); ERROR_OUT(-1606 - i, exit);
@ -1696,6 +1698,7 @@ int sha_test(void)
ret = wc_ShaFinal(&sha, hash); ret = wc_ShaFinal(&sha, hash);
if (ret != 0) if (ret != 0)
ERROR_OUT(-1805 - i, exit); ERROR_OUT(-1805 - i, exit);
wc_ShaFree(&shaCopy);
if (XMEMCMP(hash, test_sha[i].output, WC_SHA_DIGEST_SIZE) != 0) if (XMEMCMP(hash, test_sha[i].output, WC_SHA_DIGEST_SIZE) != 0)
ERROR_OUT(-1806 - i, exit); ERROR_OUT(-1806 - i, exit);
@ -1937,6 +1940,7 @@ int sha224_test(void)
ret = wc_Sha224Final(&sha, hash); ret = wc_Sha224Final(&sha, hash);
if (ret != 0) if (ret != 0)
ERROR_OUT(-2105 - i, exit); ERROR_OUT(-2105 - i, exit);
wc_Sha224Free(&shaCopy);
if (XMEMCMP(hash, test_sha[i].output, WC_SHA224_DIGEST_SIZE) != 0) if (XMEMCMP(hash, test_sha[i].output, WC_SHA224_DIGEST_SIZE) != 0)
ERROR_OUT(-2106 - i, exit); ERROR_OUT(-2106 - i, exit);
@ -2013,6 +2017,7 @@ int sha256_test(void)
ret = wc_Sha256Final(&sha, hash); ret = wc_Sha256Final(&sha, hash);
if (ret != 0) if (ret != 0)
ERROR_OUT(-2205 - i, exit); ERROR_OUT(-2205 - i, exit);
wc_Sha256Free(&shaCopy);
if (XMEMCMP(hash, test_sha[i].output, WC_SHA256_DIGEST_SIZE) != 0) if (XMEMCMP(hash, test_sha[i].output, WC_SHA256_DIGEST_SIZE) != 0)
ERROR_OUT(-2206 - i, exit); ERROR_OUT(-2206 - i, exit);
@ -2123,6 +2128,7 @@ int sha512_test(void)
ret = wc_Sha512Final(&sha, hash); ret = wc_Sha512Final(&sha, hash);
if (ret != 0) if (ret != 0)
ERROR_OUT(-2305 - i, exit); ERROR_OUT(-2305 - i, exit);
wc_Sha512Free(&shaCopy);
if (XMEMCMP(hash, test_sha[i].output, WC_SHA512_DIGEST_SIZE) != 0) if (XMEMCMP(hash, test_sha[i].output, WC_SHA512_DIGEST_SIZE) != 0)
ERROR_OUT(-2306 - i, exit); ERROR_OUT(-2306 - i, exit);
@ -2229,6 +2235,7 @@ int sha384_test(void)
ret = wc_Sha384Final(&sha, hash); ret = wc_Sha384Final(&sha, hash);
if (ret != 0) if (ret != 0)
ERROR_OUT(-2405 - i, exit); ERROR_OUT(-2405 - i, exit);
wc_Sha384Free(&shaCopy);
if (XMEMCMP(hash, test_sha[i].output, WC_SHA384_DIGEST_SIZE) != 0) if (XMEMCMP(hash, test_sha[i].output, WC_SHA384_DIGEST_SIZE) != 0)
ERROR_OUT(-2406 - i, exit); ERROR_OUT(-2406 - i, exit);
@ -3291,6 +3298,10 @@ int hmac_sha256_test(void)
if (i == 1) if (i == 1)
continue; /* cavium can't handle short keys, fips not allowed */ continue; /* cavium can't handle short keys, fips not allowed */
#endif #endif
#if defined(HAVE_INTEL_QA) || defined(HAVE_CAVIUM)
if (i == 3)
continue; /* QuickAssist can't handle empty HMAC */
#endif
if (wc_HmacInit(&hmac, HEAP_HINT, devId) != 0) if (wc_HmacInit(&hmac, HEAP_HINT, devId) != 0)
return -3500 - i; return -3500 - i;
@ -14177,6 +14188,9 @@ static int ecc_test_vector_item(const eccVector* vector)
done: done:
wc_ecc_free(&userA); wc_ecc_free(&userA);
#if !defined(NO_ASN) && !defined(HAVE_SELFTEST)
FREE_VAR(sigRaw, HEAP_HINT);
#endif
FREE_VAR(sig, HEAP_HINT); FREE_VAR(sig, HEAP_HINT);
return ret; return ret;