wolfSSL/wolfssl
1
0
Fork 1
mirror of https://github.com/wolfSSL/wolfssl.git synced 2025-07-31 19:24:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

Improve the error handling for non ECC_SECP256R1 curve in wc_ecc_make_key_ex.

Browse Source
This commit is contained in:
David Garske
2019-01-22 14:04:18 -08:00
parent c48786c649
commit 7c4fa33937
1 changed files with 18 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
wolfcrypt/src/ecc.c
View File

@@ -3897,6 +3897,7 @@ static int wc_ecc_make_pub_ex(ecc_key* key, ecc_curve_spec* curveIn,
#else #else
(void)curveIn; (void)curveIn;
err = NOT_COMPILED_IN;
#endif /* WOLFSSL_ATECC508A */ #endif /* WOLFSSL_ATECC508A */
/* change key state if public part is cached */ /* change key state if public part is cached */
@@ -3927,7 +3928,7 @@ int wc_ecc_make_pub(ecc_key* key, ecc_point* pubOut)
int wc_ecc_make_key_ex(WC_RNG* rng, int keysize, ecc_key* key, int curve_id) int wc_ecc_make_key_ex(WC_RNG* rng, int keysize, ecc_key* key, int curve_id)
{ {
int err; int err;
#ifndef WOLFSSL_ATECC508A #ifndef WOLFSSL_ATECC508A
#ifndef WOLFSSL_SP_MATH #ifndef WOLFSSL_SP_MATH
DECLARE_CURVE_SPECS(curve, ECC_CURVE_FIELD_COUNT); DECLARE_CURVE_SPECS(curve, ECC_CURVE_FIELD_COUNT);
@@ -3974,19 +3975,24 @@ int wc_ecc_make_key_ex(WC_RNG* rng, int keysize, ecc_key* key, int curve_id)
#endif /* WOLFSSL_ASYNC_CRYPT && WC_ASYNC_ENABLE_ECC */ #endif /* WOLFSSL_ASYNC_CRYPT && WC_ASYNC_ENABLE_ECC */
#ifdef WOLFSSL_ATECC508A #ifdef WOLFSSL_ATECC508A
key->type = ECC_PRIVATEKEY; if (curve_id == ECC_SECP256R1) {
key->slot = atmel_ecc_alloc(ATMEL_SLOT_ECDHE); key->type = ECC_PRIVATEKEY;
err = atmel_ecc_create_key(key->slot, key->pubkey_raw); key->slot = atmel_ecc_alloc(ATMEL_SLOT_ECDHE);
err = atmel_ecc_create_key(key->slot, key->pubkey_raw);
/* populate key->pubkey */ /* populate key->pubkey */
if (err == 0 && key->pubkey.x) { if (err == 0 && key->pubkey.x) {
err = mp_read_unsigned_bin(key->pubkey.x, key->pubkey_raw, err = mp_read_unsigned_bin(key->pubkey.x, key->pubkey_raw,
ECC_MAX_CRYPTO_HW_SIZE); ECC_MAX_CRYPTO_HW_SIZE);
}
if (err == 0 && key->pubkey.y) {
err = mp_read_unsigned_bin(key->pubkey.y,
key->pubkey_raw + ECC_MAX_CRYPTO_HW_SIZE,
ECC_MAX_CRYPTO_HW_SIZE);
}
} }
if (err == 0 && key->pubkey.y) { else {
err = mp_read_unsigned_bin(key->pubkey.y, err = NOT_COMPILED_IN;
key->pubkey_raw + ECC_MAX_CRYPTO_HW_SIZE,
ECC_MAX_CRYPTO_HW_SIZE);
} }
#else #else