Hitch code review feedback.

This commit is contained in:
Kareem
2023-07-07 10:31:18 -07:00
parent 2d0cc65381
commit 8906ee95fd
2 changed files with 3 additions and 4 deletions

View File

@ -64,7 +64,7 @@ jobs:
# Do this before configuring so that it only detects the updated list of # Do this before configuring so that it only detects the updated list of
# tests # tests
- if: ${{ matrix.ignore-tests }} - if: ${{ matrix.ignore-tests }}
name: Remove tests that we want to ignore (13, 15, 39) name: Remove tests that we want to ignore
working-directory: ./hitch/src/tests working-directory: ./hitch/src/tests
run: | run: |
rm ${{ matrix.ignore-tests }} rm ${{ matrix.ignore-tests }}
@ -83,8 +83,7 @@ jobs:
export LD_LIBRARY_PATH=$GITHUB_WORKSPACE/build-dir/lib:$LD_LIBRARY_PATH export LD_LIBRARY_PATH=$GITHUB_WORKSPACE/build-dir/lib:$LD_LIBRARY_PATH
ldd src/hitch | grep wolfssl ldd src/hitch | grep wolfssl
# Note: Exit status 77 means a test was skipped, this is valid and expected. - name: Run hitch tests, skipping ignored tests
- name: Run hitch tests, skipping 13, 15 and 39
working-directory: ./hitch working-directory: ./hitch
run: | run: |
export LD_LIBRARY_PATH=$GITHUB_WORKSPACE/build-dir/lib:$LD_LIBRARY_PATH export LD_LIBRARY_PATH=$GITHUB_WORKSPACE/build-dir/lib:$LD_LIBRARY_PATH

View File

@ -5810,7 +5810,7 @@ struct WOLFSSL {
#define SSL_STORE(ssl) ((ssl)->x509_store_pt ? (ssl)->x509_store_pt : \ #define SSL_STORE(ssl) ((ssl)->x509_store_pt ? (ssl)->x509_store_pt : \
((ssl)->ctx->x509_store_pt ? (ssl)->ctx->x509_store_pt : \ ((ssl)->ctx->x509_store_pt ? (ssl)->ctx->x509_store_pt : \
&(ssl)->ctx->x509_store)) &(ssl)->ctx->x509_store))
#define CTX_STORE(ssl) ((ctx)->x509_store_pt ? (ctx)->x509_store_pt : \ #define CTX_STORE(ctx) ((ctx)->x509_store_pt ? (ctx)->x509_store_pt : \
&(ctx)->x509_store) &(ctx)->x509_store)
#else #else
#define SSL_CM(ssl) (ssl)->ctx->cm #define SSL_CM(ssl) (ssl)->ctx->cm