wolfSSL/wolfssl
1
0
Fork 1
mirror of https://github.com/wolfSSL/wolfssl.git synced 2025-08-01 19:54:40 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fixes to make sure hash free is always called (resolves memory leaks with PIC32MZ hashing hardware). Only print Alloc/Free messages with track memory when WOLFSSL_DEBUG_MEMORY_PRINT is defined. Added test for ForceZero with 0 length.

Browse Source
This commit is contained in:
David Garske
2018-07-24 17:12:06 -07:00
parent beceab2734
commit 92cb8f06ea
4 changed files with 58 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

62
src/tls.c
View File

@@ -940,59 +940,67 @@ static int Hmac_OuterHash(Hmac* hmac, unsigned char* mac)
#ifndef NO_SHA #ifndef NO_SHA
case WC_SHA: case WC_SHA:
ret = wc_InitSha(&hmac->hash.sha); ret = wc_InitSha(&hmac->hash.sha);
if (ret == 0) if (ret == 0) {
ret = wc_ShaUpdate(&hmac->hash.sha, (byte*)hmac->opad, ret = wc_ShaUpdate(&hmac->hash.sha, (byte*)hmac->opad,
WC_SHA_BLOCK_SIZE); WC_SHA_BLOCK_SIZE);
if (ret == 0) if (ret == 0)
ret = wc_ShaUpdate(&hmac->hash.sha, (byte*)hmac->innerHash, ret = wc_ShaUpdate(&hmac->hash.sha, (byte*)hmac->innerHash,
WC_SHA_DIGEST_SIZE); WC_SHA_DIGEST_SIZE);
if (ret == 0) if (ret == 0)
ret = wc_ShaFinal(&hmac->hash.sha, mac); ret = wc_ShaFinal(&hmac->hash.sha, mac);
wc_ShaFree(&hmac->hash.sha);
}
break; break;
#endif /* !NO_SHA */ #endif /* !NO_SHA */
#ifndef NO_SHA256 #ifndef NO_SHA256
case WC_SHA256: case WC_SHA256:
ret = wc_InitSha256(&hmac->hash.sha256); ret = wc_InitSha256(&hmac->hash.sha256);
if (ret == 0) if (ret == 0) {
ret = wc_Sha256Update(&hmac->hash.sha256, (byte*)hmac->opad, ret = wc_Sha256Update(&hmac->hash.sha256, (byte*)hmac->opad,
WC_SHA256_BLOCK_SIZE); WC_SHA256_BLOCK_SIZE);
if (ret == 0) if (ret == 0)
ret = wc_Sha256Update(&hmac->hash.sha256, ret = wc_Sha256Update(&hmac->hash.sha256,
(byte*)hmac->innerHash, (byte*)hmac->innerHash,
WC_SHA256_DIGEST_SIZE); WC_SHA256_DIGEST_SIZE);
if (ret == 0) if (ret == 0)
ret = wc_Sha256Final(&hmac->hash.sha256, mac); ret = wc_Sha256Final(&hmac->hash.sha256, mac);
wc_Sha256Free(&hmac->hash.sha256);
}
break; break;
#endif /* !NO_SHA256 */ #endif /* !NO_SHA256 */
#ifdef WOLFSSL_SHA384 #ifdef WOLFSSL_SHA384
case WC_SHA384: case WC_SHA384:
ret = wc_InitSha384(&hmac->hash.sha384); ret = wc_InitSha384(&hmac->hash.sha384);
if (ret == 0) if (ret == 0) {
ret = wc_Sha384Update(&hmac->hash.sha384, (byte*)hmac->opad, ret = wc_Sha384Update(&hmac->hash.sha384, (byte*)hmac->opad,
WC_SHA384_BLOCK_SIZE); WC_SHA384_BLOCK_SIZE);
if (ret == 0) if (ret == 0)
ret = wc_Sha384Update(&hmac->hash.sha384, ret = wc_Sha384Update(&hmac->hash.sha384,
(byte*)hmac->innerHash, (byte*)hmac->innerHash,
WC_SHA384_DIGEST_SIZE); WC_SHA384_DIGEST_SIZE);
if (ret == 0) if (ret == 0)
ret = wc_Sha384Final(&hmac->hash.sha384, mac); ret = wc_Sha384Final(&hmac->hash.sha384, mac);
wc_Sha384Free(&hmac->hash.sha384);
}
break; break;
#endif /* WOLFSSL_SHA384 */ #endif /* WOLFSSL_SHA384 */
#ifdef WOLFSSL_SHA512 #ifdef WOLFSSL_SHA512
case WC_SHA512: case WC_SHA512:
ret = wc_InitSha512(&hmac->hash.sha512); ret = wc_InitSha512(&hmac->hash.sha512);
if (ret == 0) if (ret == 0) {
ret = wc_Sha512Update(&hmac->hash.sha512,(byte*)hmac->opad, ret = wc_Sha512Update(&hmac->hash.sha512,(byte*)hmac->opad,
WC_SHA512_BLOCK_SIZE); WC_SHA512_BLOCK_SIZE);
if (ret == 0) if (ret == 0)
ret = wc_Sha512Update(&hmac->hash.sha512, ret = wc_Sha512Update(&hmac->hash.sha512,
(byte*)hmac->innerHash, (byte*)hmac->innerHash,
WC_SHA512_DIGEST_SIZE); WC_SHA512_DIGEST_SIZE);
if (ret == 0) if (ret == 0)
ret = wc_Sha512Final(&hmac->hash.sha512, mac); ret = wc_Sha512Final(&hmac->hash.sha512, mac);
wc_Sha512Free(&hmac->hash.sha512);
}
break; break;
#endif /* WOLFSSL_SHA512 */ #endif /* WOLFSSL_SHA512 */
} }

3
tests/api.c
View File

@@ -20148,6 +20148,9 @@ static int test_ForceZero(void)
unsigned char data[32]; unsigned char data[32];
unsigned int i, j, len; unsigned int i, j, len;
/* Test case with 0 length */
ForceZero(data, 0);
/* Test ForceZero */ /* Test ForceZero */
for (i = 0; i < sizeof(data); i++) { for (i = 0; i < sizeof(data); i++) {
for (len = 1; len < sizeof(data) - i; len++) { for (len = 1; len < sizeof(data) - i; len++) {

26
wolfcrypt/src/hash.c
View File

@@ -658,12 +658,17 @@ int wc_HashFinal(wc_HashAlg* hash, enum wc_HashType type, byte* out)
return MEMORY_E; return MEMORY_E;
#endif #endif
ret = wc_InitMd5(md5); if ((ret = wc_InitMd5(md5)) != 0) {
if (ret == 0) { WOLFSSL_MSG("InitMd5 failed");
ret = wc_Md5Update(md5, data, len); }
if (ret == 0) { else {
ret = wc_Md5Final(md5, hash); if ((ret = wc_Md5Update(md5, data, len)) != 0) {
WOLFSSL_MSG("Md5Update failed");
} }
else if ((ret = wc_Md5Final(md5, hash)) != 0) {
WOLFSSL_MSG("Md5Final failed");
}
wc_Md5Free(md5);
} }
#ifdef WOLFSSL_SMALL_STACK #ifdef WOLFSSL_SMALL_STACK
@@ -691,11 +696,16 @@ int wc_HashFinal(wc_HashAlg* hash, enum wc_HashType type, byte* out)
#endif #endif
if ((ret = wc_InitSha(sha)) != 0) { if ((ret = wc_InitSha(sha)) != 0) {
WOLFSSL_MSG("wc_InitSha failed"); WOLFSSL_MSG("InitSha failed");
} }
else { else {
wc_ShaUpdate(sha, data, len); if ((ret = wc_ShaUpdate(sha, data, len)) != 0) {
wc_ShaFinal(sha, hash); WOLFSSL_MSG("ShaUpdate failed");
}
else if ((ret = wc_ShaFinal(sha, hash)) != 0) {
WOLFSSL_MSG("ShaFinal failed");
}
wc_ShaFree(sha);
} }
#ifdef WOLFSSL_SMALL_STACK #ifdef WOLFSSL_SMALL_STACK

4
wolfssl/wolfcrypt/mem_track.h
View File

@@ -123,7 +123,7 @@
mt->u.hint.thisSize = sz; mt->u.hint.thisSize = sz;
mt->u.hint.thisMemory = (byte*)mt + sizeof(memoryTrack); mt->u.hint.thisMemory = (byte*)mt + sizeof(memoryTrack);
#ifdef WOLFSSL_DEBUG_MEMORY #ifdef WOLFSSL_DEBUG_MEMORY_PRINT
printf("Alloc: %p -> %u at %s:%d\n", mt->u.hint.thisMemory, (word32)sz, func, line); printf("Alloc: %p -> %u at %s:%d\n", mt->u.hint.thisMemory, (word32)sz, func, line);
#endif #endif
@@ -159,7 +159,7 @@
ourMemStats.totalDeallocs++; ourMemStats.totalDeallocs++;
#endif #endif
#ifdef WOLFSSL_DEBUG_MEMORY #ifdef WOLFSSL_DEBUG_MEMORY_PRINT
printf("Free: %p -> %u at %s:%d\n", ptr, (word32)mt->u.hint.thisSize, func, line); printf("Free: %p -> %u at %s:%d\n", ptr, (word32)mt->u.hint.thisSize, func, line);
#endif #endif