Don't create a key if we don't support the curve.

Found with the following configuration:

./configure --enable-tls13 --disable-oldtls --enable-static --enable-singlethreaded --enable-dtls --enable-dtls13 --enable-dtls-mtu --enable-sp=yes,4096 --disable-shared --disable-sha3 --disable-dh --enable-curve25519 --enable-secure-renegotiation --enable-debug --enable-opensslextra 'CFLAGS=-DWOLFSSL_DTLS_ALLOW_FUTURE -DWOLFSSL_MIN_RSA_BITS=2048 -DWOLFSSL_MIN_ECC_BITS=256 -DFP_MAX_BITS=8192 -fomit-frame-pointer'
This commit is contained in:
Anthony Hu
2022-12-08 12:10:19 -05:00
parent eb69ccb22c
commit 937d247c7d
2 changed files with 9 additions and 2 deletions

View File

@ -9168,12 +9168,19 @@ WOLFSSL_EC_KEY *wolfSSL_EC_KEY_new_by_curve_name(int nid)
if (eccEnum != -1) { if (eccEnum != -1) {
/* search and set the corresponding internal curve idx */ /* search and set the corresponding internal curve idx */
for (x = 0; ecc_sets[x].size != 0; x++) for (x = 0; ecc_sets[x].size != 0; x++) {
if (ecc_sets[x].id == eccEnum) { if (ecc_sets[x].id == eccEnum) {
key->group->curve_idx = x; key->group->curve_idx = x;
key->group->curve_oid = ecc_sets[x].oidSum; key->group->curve_oid = ecc_sets[x].oidSum;
break; break;
} }
}
/* if not found, we don't support this curve. */
if (ecc_sets[x].size == 0) {
wolfSSL_EC_KEY_free(key);
key = NULL;
}
} }
return key; return key;

View File

@ -46165,7 +46165,7 @@ static int test_wolfSSL_EC_KEY_print_fp(void)
{ {
int res = TEST_SKIPPED; int res = TEST_SKIPPED;
#if defined(HAVE_ECC) && ((defined(HAVE_ECC224) && defined(HAVE_ECC256)) || \ #if defined(HAVE_ECC) && ((defined(HAVE_ECC224) && defined(HAVE_ECC256)) || \
defined(HAVE_ALL_CURVES)) && ECC_MIN_KEY_SZ <= 256 && \ defined(HAVE_ALL_CURVES)) && ECC_MIN_KEY_SZ <= 224 && \
defined(OPENSSL_EXTRA) && defined(XFPRINTF) && !defined(NO_FILESYSTEM) && \ defined(OPENSSL_EXTRA) && defined(XFPRINTF) && !defined(NO_FILESYSTEM) && \
!defined(NO_STDIO_FILESYSTEM) !defined(NO_STDIO_FILESYSTEM)
EC_KEY* key = NULL; EC_KEY* key = NULL;