From 9b2f7a371f76eabfa62868c625bed05c959f37ef Mon Sep 17 00:00:00 2001 From: Ruby Martin Date: Wed, 5 Nov 2025 15:27:26 -0700 Subject: [PATCH] remove duplicate keylen check (deadcode) wrap if statement in macro guard --- wolfcrypt/src/aes.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/wolfcrypt/src/aes.c b/wolfcrypt/src/aes.c index 8b0543841..4c43d4ebd 100644 --- a/wolfcrypt/src/aes.c +++ b/wolfcrypt/src/aes.c @@ -4777,18 +4777,17 @@ static void AesSetKey_C(Aes* aes, const byte* key, word32 keySz, int dir) } #endif + #if defined(AES_MAX_KEY_SIZE) && AES_MAX_KEY_SIZE < 256 if (checkKeyLen) { - if (keylen != 16 && keylen != 24 && keylen != 32) { - return BAD_FUNC_ARG; - } - #if defined(AES_MAX_KEY_SIZE) && AES_MAX_KEY_SIZE < 256 /* Check key length only when AES_MAX_KEY_SIZE doesn't allow * all key sizes. Otherwise this condition is never true. */ if (keylen > (AES_MAX_KEY_SIZE / 8)) { return BAD_FUNC_ARG; } - #endif } + #else + (void) checkKeyLen; + #endif #if defined(WOLFSSL_AES_COUNTER) || defined(WOLFSSL_AES_CFB) || \ defined(WOLFSSL_AES_OFB) || defined(WOLFSSL_AES_XTS) || \