From a46fd6612bd7656c6292687cfcb59c70ee776362 Mon Sep 17 00:00:00 2001 From: David Garske Date: Thu, 25 Feb 2016 14:35:54 +0100 Subject: [PATCH] Changed CopyDecodedToX509 AllocDer error code handing to return MEMORY_E, since that is an explicitly handled case. Also resolves the issue with "warning: Value stored to 'ret' is never read". --- src/internal.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/internal.c b/src/internal.c index 4788dc501..10aa7349a 100644 --- a/src/internal.c +++ b/src/internal.c @@ -4469,10 +4469,12 @@ int CopyDecodedToX509(WOLFSSL_X509* x509, DecodedCert* dCert) } /* store cert for potential retrieval */ - ret = AllocDer(&x509->derCert, dCert->maxIdx, CERT_TYPE, NULL); - if (ret == 0) { + if (AllocDer(&x509->derCert, dCert->maxIdx, CERT_TYPE, NULL) == 0) { XMEMCPY(x509->derCert.buffer, dCert->source, dCert->maxIdx); } + else { + ret = MEMORY_E; + } x509->altNames = dCert->altNames; dCert->weOwnAltNames = 0;