From ac885c40f0e6669e5f4a9ca381d7af1bd7d701c9 Mon Sep 17 00:00:00 2001 From: John Safranek Date: Fri, 4 Jan 2013 13:13:20 -0800 Subject: [PATCH] fix a memory leak when OCSP lookup fails --- src/ocsp.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/ocsp.c b/src/ocsp.c index ff06b84bc..1826e6ee8 100644 --- a/src/ocsp.c +++ b/src/ocsp.c @@ -298,8 +298,6 @@ int CyaSSL_OCSP_Lookup_Cert(CYASSL_OCSP* ocsp, DecodedCert* cert) result = ocsp->CBIOOcsp(ocsp->IOCB_OcspCtx, url, urlSz, ocspReqBuf, ocspReqSz, &ocspRespBuf); } - else - return OCSP_LOOKUP_FAIL; if (result >= 0) { InitOcspResponse(&ocspResponse, certStatus, ocspRespBuf, result); @@ -320,6 +318,10 @@ int CyaSSL_OCSP_Lookup_Cert(CYASSL_OCSP* ocsp, DecodedCert* cert) } } } + else { + result = OCSP_LOOKUP_FAIL; + } + if (ocspReqBuf != NULL) { XFREE(ocspReqBuf, NULL, DYNAMIC_TYPE_IN_BUFFER); }