wolfSSL/wolfssl
1
0
Fork 1
mirror of https://github.com/wolfSSL/wolfssl.git synced 2025-08-02 12:14:38 +02:00
Code Issues Packages Projects Releases Wiki Activity

Unit Test: fix test case for memory allocation failure testing

Browse Source 
test_ocsp_basic_verify() not freeing and setting pointer to NULL. Second
free occuring on freed pointer.
This commit is contained in:
Sean Parkinson
2025-07-02 09:27:25 +10:00
parent ff80d62db2
commit af05fa874f
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tests/api/test_ocsp.c
View File

@@ -243,6 +243,7 @@ int test_ocsp_basic_verify(void)
ExpectIntEQ(wolfSSL_OCSP_basic_verify(response, NULL, NULL, OCSP_NOVERIFY), ExpectIntEQ(wolfSSL_OCSP_basic_verify(response, NULL, NULL, OCSP_NOVERIFY),
WOLFSSL_FAILURE); WOLFSSL_FAILURE);
wolfSSL_OCSP_RESPONSE_free(response); wolfSSL_OCSP_RESPONSE_free(response);
response = NULL;
/* populate a store with root-ca-cert */ /* populate a store with root-ca-cert */
ExpectIntEQ(test_ocsp_create_x509store(&store, root_ca_cert_pem, ExpectIntEQ(test_ocsp_create_x509store(&store, root_ca_cert_pem,
@@ -261,6 +262,7 @@ int test_ocsp_basic_verify(void)
ExpectIntEQ(wolfSSL_OCSP_basic_verify(response, certs, store, 0), ExpectIntEQ(wolfSSL_OCSP_basic_verify(response, certs, store, 0),
WOLFSSL_SUCCESS); WOLFSSL_SUCCESS);
wolfSSL_OCSP_RESPONSE_free(response); wolfSSL_OCSP_RESPONSE_free(response);
response = NULL;
/* cert embedded, verified using store */ /* cert embedded, verified using store */
ptr = (const unsigned char*)resp; ptr = (const unsigned char*)resp;
@@ -290,6 +292,7 @@ int test_ocsp_basic_verify(void)
ExpectIntNE(wolfSSL_OCSP_basic_verify(response, NULL, store, OCSP_NOINTERN), ExpectIntNE(wolfSSL_OCSP_basic_verify(response, NULL, store, OCSP_NOINTERN),
WOLFSSL_SUCCESS); WOLFSSL_SUCCESS);
wolfSSL_OCSP_RESPONSE_free(response); wolfSSL_OCSP_RESPONSE_free(response);
response = NULL;
/* cert not embedded, not certs */ /* cert not embedded, not certs */
ptr = (const unsigned char*)resp_nocert; ptr = (const unsigned char*)resp_nocert;
@@ -298,9 +301,12 @@ int test_ocsp_basic_verify(void)
ExpectIntNE(wolfSSL_OCSP_basic_verify(response, NULL, store, 0), ExpectIntNE(wolfSSL_OCSP_basic_verify(response, NULL, store, 0),
WOLFSSL_SUCCESS); WOLFSSL_SUCCESS);
wolfSSL_OCSP_RESPONSE_free(response); wolfSSL_OCSP_RESPONSE_free(response);
response = NULL;
wolfSSL_sk_X509_pop_free(certs, wolfSSL_X509_free); wolfSSL_sk_X509_pop_free(certs, wolfSSL_X509_free);
certs = NULL;
wolfSSL_X509_STORE_free(store); wolfSSL_X509_STORE_free(store);
store = NULL;
ExpectIntEQ(test_ocsp_create_x509store(&store, root_ca_cert_pem, ExpectIntEQ(test_ocsp_create_x509store(&store, root_ca_cert_pem,
sizeof(root_ca_cert_pem)), sizeof(root_ca_cert_pem)),
@@ -316,6 +322,7 @@ int test_ocsp_basic_verify(void)
ExpectIntEQ(wolfSSL_OCSP_basic_verify(response, certs, store, 0), ExpectIntEQ(wolfSSL_OCSP_basic_verify(response, certs, store, 0),
WOLFSSL_SUCCESS); WOLFSSL_SUCCESS);
wolfSSL_OCSP_RESPONSE_free(response); wolfSSL_OCSP_RESPONSE_free(response);
response = NULL;
/* cert in certs, cert verified on store, not authorized to verify all /* cert in certs, cert verified on store, not authorized to verify all
* responses */ * responses */