wolfSSL/wolfssl
1
0
Fork 1
mirror of https://github.com/wolfSSL/wolfssl.git synced 2025-07-31 19:24:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

Replace immediate value "0" with WOLFSSL_FAILURE and add comment to the RETURN_CODE macro

Browse Source
This commit is contained in:
TakayukiMatsuo
2021-03-03 11:23:11 +09:00
parent 4264a49246
commit bbf1284112
3 changed files with 18 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/ssl.c
View File

@@ -6916,7 +6916,7 @@ int wolfSSL_CTX_load_verify_locations(WOLFSSL_CTX* ctx, const char* file,
int ret = wolfSSL_CTX_load_verify_locations_ex(ctx, file, path, int ret = wolfSSL_CTX_load_verify_locations_ex(ctx, file, path,
WOLFSSL_LOAD_VERIFY_DEFAULT_FLAGS); WOLFSSL_LOAD_VERIFY_DEFAULT_FLAGS);
return RETURN_CODE(ret,0); return RETURN_CODE(ret,WOLFSSL_FAILURE);
} }
@@ -24409,15 +24409,15 @@ int wolfSSL_X509_LOOKUP_load_file(WOLFSSL_X509_LOOKUP* lookup,
const char* footer = NULL; const char* footer = NULL;
if (type != X509_FILETYPE_PEM) if (type != X509_FILETYPE_PEM)
return RETURN_CODE(BAD_FUNC_ARG,0); return RETURN_CODE(BAD_FUNC_ARG,WOLFSSL_FAILURE);
fp = XFOPEN(file, "rb"); fp = XFOPEN(file, "rb");
if (fp == XBADFILE) if (fp == XBADFILE)
return RETURN_CODE(BAD_FUNC_ARG,0); return RETURN_CODE(BAD_FUNC_ARG,WOLFSSL_FAILURE);
if(XFSEEK(fp, 0, XSEEK_END) != 0) { if(XFSEEK(fp, 0, XSEEK_END) != 0) {
XFCLOSE(fp); XFCLOSE(fp);
return RETURN_CODE(WOLFSSL_BAD_FILE,0); return RETURN_CODE(WOLFSSL_BAD_FILE,WOLFSSL_FAILURE);
} }
sz = XFTELL(fp); sz = XFTELL(fp);
XREWIND(fp); XREWIND(fp);
@@ -24487,12 +24487,12 @@ end:
if (pem != NULL) if (pem != NULL)
XFREE(pem, 0, DYNAMIC_TYPE_PEM); XFREE(pem, 0, DYNAMIC_TYPE_PEM);
XFCLOSE(fp); XFCLOSE(fp);
return RETURN_CODE(ret,0); return RETURN_CODE(ret,WOLFSSL_FAILURE);
#else #else
(void)lookup; (void)lookup;
(void)file; (void)file;
(void)type; (void)type;
return RETURN_CODE(WOLFSSL_FAILURE,0); return RETURN_CODE(WOLFSSL_FAILURE,WOLFSSL_FAILURE);
#endif #endif
} }

6
tests/api.c
View File

@@ -954,19 +954,19 @@ static void test_wolfSSL_CTX_load_verify_locations(void)
/* invalid ca file */ /* invalid ca file */
AssertIntEQ(wolfSSL_CTX_load_verify_locations(ctx, bogusFile, NULL), AssertIntEQ(wolfSSL_CTX_load_verify_locations(ctx, bogusFile, NULL),
RETURN_CODE(WOLFSSL_BAD_FILE,0)); RETURN_CODE(WOLFSSL_BAD_FILE,WOLFSSL_FAILURE));
#if !defined(NO_WOLFSSL_DIR) && !defined(WOLFSSL_TIRTOS) #if !defined(NO_WOLFSSL_DIR) && !defined(WOLFSSL_TIRTOS)
/* invalid path */ /* invalid path */
AssertIntEQ(wolfSSL_CTX_load_verify_locations(ctx, NULL, bogusFile), AssertIntEQ(wolfSSL_CTX_load_verify_locations(ctx, NULL, bogusFile),
RETURN_CODE(BAD_PATH_ERROR,0)); RETURN_CODE(BAD_PATH_ERROR,WOLFSSL_FAILURE));
#endif #endif
/* load ca cert */ /* load ca cert */
#ifdef NO_RSA #ifdef NO_RSA
AssertIntEQ(wolfSSL_CTX_load_verify_locations(ctx, caCertFile, NULL), AssertIntEQ(wolfSSL_CTX_load_verify_locations(ctx, caCertFile, NULL),
RETURN_CODE(ASN_UNKNOWN_OID_E,0)); RETURN_CODE(ASN_UNKNOWN_OID_E,WOLFSSL_FAILURE));
#else /* Skip the following test without RSA certs. */ #else /* Skip the following test without RSA certs. */
AssertIntEQ(wolfSSL_CTX_load_verify_locations(ctx, caCertFile, NULL), WOLFSSL_SUCCESS); AssertIntEQ(wolfSSL_CTX_load_verify_locations(ctx, caCertFile, NULL), WOLFSSL_SUCCESS);

9
wolfssl/ssl.h
View File

@@ -674,6 +674,15 @@ enum AlertLevel {
alert_fatal = 2 alert_fatal = 2
}; };
/* RETURN_CODE macro
* Some OpenSSL APIs specify "0" as the return value when an error occurs.
* However, some corresponding wolfSSL APIs(eg.
* wolfSSL_CTX_load_verify_locations) return negative values. Such functions
* should use this macro to fill this gap. Users who want them to return
* the same return value as OpenSSL can define WOLFSSL_ERR_CODE_OPENSSL.
* Note that this macro replaces only negative return values with the
* specified value.
*/
#if defined(WOLFSSL_ERROR_CODE_OPENSSL) #if defined(WOLFSSL_ERROR_CODE_OPENSSL)
#define RETURN_CODE(w,o) ((w < 0)?o:w) #define RETURN_CODE(w,o) ((w < 0)?o:w)
#else #else