From c17217ce3190deda4d9b153dfe8cfbf65bf688c4 Mon Sep 17 00:00:00 2001 From: Ruby Martin Date: Thu, 19 Feb 2026 15:43:41 -0700 Subject: [PATCH] add null check in test_wolfSSL_X509_CRL_sign_large() init revoked --- tests/api.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/tests/api.c b/tests/api.c index 3af30a5542..cc66270c6e 100644 --- a/tests/api.c +++ b/tests/api.c @@ -21141,7 +21141,7 @@ static int test_wolfSSL_X509_CRL_sign_large(void) WOLFSSL_X509_CRL* crl = NULL; WOLFSSL_EVP_PKEY* pkey = NULL; WOLFSSL_ASN1_TIME asnTime; - WOLFSSL_X509_REVOKED revoked; + WOLFSSL_X509_REVOKED revoked = {0}; XFILE fp = XBADFILE; int i; byte serial[4]; @@ -21166,9 +21166,11 @@ static int test_wolfSSL_X509_CRL_sign_large(void) ExpectIntEQ(wolfSSL_X509_CRL_set_nextUpdate(crl, &asnTime), WOLFSSL_SUCCESS); - revoked.serialNumber = wolfSSL_ASN1_INTEGER_new(); - revoked.serialNumber->data = serial; - revoked.serialNumber->length = (int)sizeof(serial); + ExpectNotNull(revoked.serialNumber = wolfSSL_ASN1_INTEGER_new()); + if (revoked.serialNumber != NULL) { + revoked.serialNumber->data = serial; + revoked.serialNumber->length = (int)sizeof(serial); + } for (i = 1; i <= 1024; i++) { serial[0] = (byte)(i & 0xff); @@ -21189,9 +21191,11 @@ static int test_wolfSSL_X509_CRL_sign_large(void) ExpectIntEQ(wolfSSL_X509_CRL_sign(crl, pkey, wolfSSL_EVP_sha256()), WOLFSSL_SUCCESS); - revoked.serialNumber->data = NULL; - wolfSSL_ASN1_INTEGER_free(revoked.serialNumber); - revoked.serialNumber = NULL; + if (revoked.serialNumber != NULL) { + revoked.serialNumber->data = NULL; + wolfSSL_ASN1_INTEGER_free(revoked.serialNumber); + revoked.serialNumber = NULL; + } wolfSSL_EVP_PKEY_free(pkey); wolfSSL_X509_CRL_free(crl);