From d6c8e7bced1414362b1720985dc2c0a619f429aa Mon Sep 17 00:00:00 2001 From: Ruby Martin Date: Thu, 26 Feb 2026 17:13:48 -0700 Subject: [PATCH] add tmp variable to satisfy coverity before casting and assigning to word32 variable --- wolfcrypt/src/asn.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/wolfcrypt/src/asn.c b/wolfcrypt/src/asn.c index af1a2ef917..e1db227080 100644 --- a/wolfcrypt/src/asn.c +++ b/wolfcrypt/src/asn.c @@ -42214,6 +42214,7 @@ static int EncodeCrlSerial(const byte* sn, word32 snSz, byte* output, */ static word32 EncodeRevokedCert(byte* output, const RevokedCert* rc) { + int tmpSnSz; word32 idx = 0; word32 snSz, dateSz, seqSz; byte snBuf[MAX_SN_SZ]; @@ -42221,10 +42222,11 @@ static word32 EncodeRevokedCert(byte* output, const RevokedCert* rc) byte seqBuf[MAX_SEQ_SZ]; /* Encode serial number */ - snSz = (word32)EncodeCrlSerial(rc->serialNumber, (word32)rc->serialSz, + tmpSnSz = EncodeCrlSerial(rc->serialNumber, (word32)rc->serialSz, snBuf, sizeof(snBuf)); - if ((int)snSz < 0) + if (tmpSnSz < 0) return 0; + snSz = (word32)tmpSnSz; /* Encode revocation date */ dateSz = EncodeCrlDate(dateBuf, rc->revDate, rc->revDateFormat); @@ -42255,6 +42257,7 @@ static word32 EncodeRevokedCert(byte* output, const RevokedCert* rc) static word32 EncodeCrlNumberExt(byte* output, const byte* crlNum, word32 crlNumSz) { + int tmpIntSz; word32 idx = 0; word32 oidSz, intSz, octetSz, seqSz; byte seqBuf[MAX_SEQ_SZ]; @@ -42266,9 +42269,10 @@ static word32 EncodeCrlNumberExt(byte* output, const byte* crlNum, oidSz = sizeof(crlNumOid); /* Encode the INTEGER for CRL number */ - intSz = (word32)EncodeCrlSerial(crlNum, crlNumSz, intBuf, sizeof(intBuf)); - if ((int)intSz < 0) + tmpIntSz = EncodeCrlSerial(crlNum, crlNumSz, intBuf, sizeof(intBuf)); + if (tmpIntSz < 0) return 0; + intSz = (word32)tmpIntSz; /* Wrap INTEGER in OCTET STRING */ octetSz = SetOctetString(intSz, octetBuf);